From 79ec63918cf58531247330e93a1e302915f9cb7a Mon Sep 17 00:00:00 2001 From: Jan Jahoda Date: Tue, 25 Aug 2020 11:13:41 +0200 Subject: [PATCH] Missed cases not discovered during first phase (#40382) Co-authored-by: Jan Jahoda --- .../System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs | 2 +- .../tests/UserPrincipalTest.cs | 2 +- .../System.Security.Cryptography.X509Certificates/tests/TestData.cs | 2 ++ 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs b/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs index 7b91de7..9664c1c 100644 --- a/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs +++ b/src/libraries/System.DirectoryServices.AccountManagement/tests/PrincipalTest.cs @@ -15,7 +15,7 @@ namespace System.DirectoryServices.AccountManagement.Tests private void RefreshContext() { - // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test dummy credentials.")] + // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")] string username = "Administrator", password = "Adrumble@6"; string OU = "Tests"; diff --git a/src/libraries/System.DirectoryServices.AccountManagement/tests/UserPrincipalTest.cs b/src/libraries/System.DirectoryServices.AccountManagement/tests/UserPrincipalTest.cs index 22fa3f7..a67aaa8 100644 --- a/src/libraries/System.DirectoryServices.AccountManagement/tests/UserPrincipalTest.cs +++ b/src/libraries/System.DirectoryServices.AccountManagement/tests/UserPrincipalTest.cs @@ -31,7 +31,7 @@ namespace System.DirectoryServices.AccountManagement.Tests public void ComputedUACCheck() { - // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test dummy credentials.")] + // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")] string username = "Administrator", password = "Adrumble@6"; //TODO: don't assume it exists, create it if its not string OU = "TestNull"; diff --git a/src/libraries/System.Security.Cryptography.X509Certificates/tests/TestData.cs b/src/libraries/System.Security.Cryptography.X509Certificates/tests/TestData.cs index 94f5458..845ca72 100644 --- a/src/libraries/System.Security.Cryptography.X509Certificates/tests/TestData.cs +++ b/src/libraries/System.Security.Cryptography.X509Certificates/tests/TestData.cs @@ -153,6 +153,7 @@ tcCZhP5KEu6XKKc1GcTqbyA0vi92YyyZViUa36hhVrNqPxtpclir+lcnNgnlqg== -----END CERTIFICATE----- "); + // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")] public const string PfxDataPassword = "12345"; public static SecureString CreatePfxDataPasswordSecureString() @@ -476,6 +477,7 @@ tcCZhP5KEu6XKKc1GcTqbyA0vi92YyyZViUa36hhVrNqPxtpclir+lcnNgnlqg== "313021300906052B0E03021A0500041466FD3518CEBBD69877BA663C9E8D7092" + "8E8A98F30408DFB5AE610308BCF802020800").HexToByteArray(); + // [SuppressMessage("Microsoft.Security", "CS002:SecretInNextLine", Justification="Unit test password.")] public const string Dsa1024PfxPassword = "1234"; public static byte[] Dsa1024Cert = ( -- 2.7.4