From 79a0330a525777af58e45836424c62ac67b935e5 Mon Sep 17 00:00:00 2001 From: Mehdi Amini Date: Fri, 10 Dec 2021 05:02:25 +0000 Subject: [PATCH] Fix crash from use of a temporary after its scope exit Introduced in D110448 and broke some bots (reported by ASAN). Differential Revision: https://reviews.llvm.org/D110448 --- mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp b/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp index c72d211..8c269ee 100644 --- a/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp +++ b/mlir/lib/Conversion/GPUCommon/GPUOpsLowering.cpp @@ -238,11 +238,10 @@ LogicalResult GPUPrintfOpToHIPLowering::matchAndRewrite( Value zeroI32 = rewriter.create( loc, llvmI32, rewriter.getI32IntegerAttr(0)); - mlir::ValueRange appendFormatArgs = {printfDesc, stringStart, stringLen, - adaptor.args().empty() ? oneI32 - : zeroI32}; - auto appendFormatCall = - rewriter.create(loc, ocklAppendStringN, appendFormatArgs); + auto appendFormatCall = rewriter.create( + loc, ocklAppendStringN, + ValueRange{printfDesc, stringStart, stringLen, + adaptor.args().empty() ? oneI32 : zeroI32}); printfDesc = appendFormatCall.getResult(0); // __ockl_printf_append_args takes 7 values per append call -- 2.7.4