From 791324cc06423ffea9a7f397150e1415395d19c1 Mon Sep 17 00:00:00 2001 From: =?utf8?q?John=20K=C3=A5re=20Alsaker?= Date: Thu, 10 Apr 2014 20:05:17 +0200 Subject: [PATCH] gl-renderer: Remove gl_renderer_interface from gl-renderer.h The rationale here is, that this line would create an instance of gl_renderer_interface in every compilation unit that included gl-renderer.h. This is not necessary, and it can actually be harmful by masking the real exported gl_renderer_interface symbol, if you added another compilation unit to gl-renderer.so, causing a runtime failure in loading it. gl-renderer.c already creates the exported symbol. --- src/gl-renderer.h | 1 - 1 file changed, 1 deletion(-) diff --git a/src/gl-renderer.h b/src/gl-renderer.h index bdfe93e..77b1952 100644 --- a/src/gl-renderer.h +++ b/src/gl-renderer.h @@ -101,4 +101,3 @@ struct gl_renderer_interface { void (*print_egl_error_state)(void); }; -struct gl_renderer_interface gl_renderer_interface; -- 2.7.4