From 78a2ea4199b0292a4fada84baa2db53f6b67e0f0 Mon Sep 17 00:00:00 2001 From: Jason Merrill Date: Wed, 13 Feb 2013 12:56:05 -0500 Subject: [PATCH] re PR c++/56135 ([c++11] this incorrectly captured as null in template member function) PR c++/56135 * pt.c (tsubst_copy_and_build): Don't forget any new captures that arose from use of dependent names. From-SVN: r196021 --- gcc/cp/ChangeLog | 6 ++++ gcc/cp/pt.c | 6 ++-- gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C | 39 ++++++++++++++++++++++++ 3 files changed, 49 insertions(+), 2 deletions(-) create mode 100644 gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C diff --git a/gcc/cp/ChangeLog b/gcc/cp/ChangeLog index 442b369..e3b927b 100644 --- a/gcc/cp/ChangeLog +++ b/gcc/cp/ChangeLog @@ -1,3 +1,9 @@ +2013-02-13 Jason Merrill + + PR c++/56135 + * pt.c (tsubst_copy_and_build): Don't forget any new + captures that arose from use of dependent names. + 2013-02-13 Jakub Jelinek PR c++/56302 diff --git a/gcc/cp/pt.c b/gcc/cp/pt.c index a3359ad..2aadd4d 100644 --- a/gcc/cp/pt.c +++ b/gcc/cp/pt.c @@ -14457,9 +14457,11 @@ tsubst_copy_and_build (tree t, complete_type (type); /* The capture list refers to closure members, so this needs to - wait until after we finish instantiating the type. */ + wait until after we finish instantiating the type. Also keep + any captures that may have been added during instantiation. */ LAMBDA_EXPR_CAPTURE_LIST (r) - = RECUR (LAMBDA_EXPR_CAPTURE_LIST (t)); + = chainon (RECUR (LAMBDA_EXPR_CAPTURE_LIST (t)), + LAMBDA_EXPR_CAPTURE_LIST (r)); LAMBDA_EXPR_THIS_CAPTURE (r) = NULL_TREE; RETURN (build_lambda_object (r)); diff --git a/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C new file mode 100644 index 0000000..9309a44 --- /dev/null +++ b/gcc/testsuite/g++.dg/cpp0x/lambda/lambda-this8.C @@ -0,0 +1,39 @@ +// PR c++/56135 +// { dg-do run { target c++11 } } + +#include + +extern "C" void abort() throw(); + +struct test { + template + std::function broken(int x) { + return [=] { +x; print(); }; + } + + std::function works0() { + return [=] { print(); }; + } + + template + std::function works1() { + return [=] { print(); }; + } + + template + std::function works2() { + return [=] { this->print(); }; + } + + template + void print() { if (this == NULL) abort (); } +}; + +int main(void) { + test().broken(1)(); + test().works0()(); + test().works1()(); + test().works2()(); + + return 0; +} -- 2.7.4