From 77d0c993df4b422e347ce97b5c199f9a2dca6dd2 Mon Sep 17 00:00:00 2001 From: SeungSeop Park Date: Fri, 15 Jan 2016 09:25:46 +0900 Subject: [PATCH] Enforce "treat warning as error" policy for chromium-ewk 1. Remove top-level "-Dwerror=" gyp define from gyp_chromiumefl.sh. This will let chromium targets use their own policy regarding whether to treat warnings as error or ignore them. 2. Add '-Werror' cflag to chromium-ewk target. Bug: http://web.sec.samsung.net/bugzilla/show_bug.cgi?id=15612 Reviewed by: a1.gomes, g.czajkowski Change-Id: Id2634bcb1958c53ddc53a4259404d3cf54047a66 Signed-off-by: SeungSeop Park --- tizen_src/build/gyp_chromiumefl.sh | 1 - tizen_src/ewk/efl_integration/efl_integration.gypi | 8 ++++++++ 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/tizen_src/build/gyp_chromiumefl.sh b/tizen_src/build/gyp_chromiumefl.sh index 309fd23..e41769b 100755 --- a/tizen_src/build/gyp_chromiumefl.sh +++ b/tizen_src/build/gyp_chromiumefl.sh @@ -113,7 +113,6 @@ add_arm_flags() { add_tizen_flags() { ADDITIONAL_GYP_PARAMETERS+="-Dbuilding_for_tizen=1 -Dtizen=1 - -Dwerror= -Dpython_ver=$(getPythonVersion) -Denable_basic_printing=1 -Denable_print_preview=1 diff --git a/tizen_src/ewk/efl_integration/efl_integration.gypi b/tizen_src/ewk/efl_integration/efl_integration.gypi index 646cb5d..47780d0 100644 --- a/tizen_src/ewk/efl_integration/efl_integration.gypi +++ b/tizen_src/ewk/efl_integration/efl_integration.gypi @@ -86,6 +86,14 @@ # Symbol visibility controled by chromium-ewk.filter '-fvisibility=hidden', ], + 'cflags/': [ + # Treat warning as error for this target. + # It needs to be included by means of pattern list because '-Werror' cflag + # will be excluded in chromium side (src/build/common.gypi), and GYP + # processes pattern lists after exclusion lists. + # (ref: https://gyp.gsrc.io/docs/InputFormatReference.md#Processing-Order) + ['include', '-Werror'], + ], 'conditions': [ ['xwalk_link_against_chromium_ewk==0', { 'variables': { -- 2.7.4