From 7789e3bb50b52352562d9e22f66e6e089cfeff6b Mon Sep 17 00:00:00 2001 From: Tobin Ehlis Date: Thu, 26 Oct 2017 17:25:05 -0600 Subject: [PATCH] icd:Get more tests passing on mock ICD Modifying hard-coded minImageTransferGranularity for the queue from {0,0,0}, which has special restrictions, to {1,1,1} which is more lenient and removes some unexpected errors, allowing six more tests to pass. --- icd/README.md | 6 ------ scripts/mock_icd_generator.py | 2 +- 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/icd/README.md b/icd/README.md index 6859fd1..8905577 100644 --- a/icd/README.md +++ b/icd/README.md @@ -65,12 +65,6 @@ Currently 324/332 tests are passing with the mock icd, but many passing tests ha ### Failing Tests -VkLayerTest.ImageFormatLimits -VkLayerTest.CopyImageTypeExtentMismatch -VkLayerTest.CopyImageCompressedBlockAlignment -VkLayerTest.CopyImageSrcSizeExceeded -VkLayerTest.CopyImageDstSizeExceeded -VkPositiveLayerTest.UncompressedToCompressedImageCopy VkPositiveLayerTest.EmptyDescriptorUpdateTest ### Passing Tests With Unexpected Errors diff --git a/scripts/mock_icd_generator.py b/scripts/mock_icd_generator.py index e9dda6f..6dbcab0 100644 --- a/scripts/mock_icd_generator.py +++ b/scripts/mock_icd_generator.py @@ -569,7 +569,7 @@ CUSTOM_C_INTERCEPTS = { pQueueFamilyProperties[0].queueFlags = VK_QUEUE_GRAPHICS_BIT | VK_QUEUE_COMPUTE_BIT | VK_QUEUE_TRANSFER_BIT | VK_QUEUE_SPARSE_BINDING_BIT; pQueueFamilyProperties[0].queueCount = 1; pQueueFamilyProperties[0].timestampValidBits = 0; - pQueueFamilyProperties[0].minImageTransferGranularity = {0,0,0}; + pQueueFamilyProperties[0].minImageTransferGranularity = {1,1,1}; } } ''', -- 2.7.4