From 7763838e991e4d17a24c4214db5144eefd515543 Mon Sep 17 00:00:00 2001 From: Cupertino Miranda Date: Fri, 26 Aug 2016 22:15:23 +0200 Subject: [PATCH] Fixed issue with NULL pointer access on header var. Variable "header" in function is set conditionally, but was accessed without verifying if pointer was NULL. opcodes/ChangeLog: Cupertino Miranda * opcodes/arc-dis.c (print_insn_arc): Changed. --- opcodes/ChangeLog | 4 ++++ opcodes/arc-dis.c | 5 ++++- 2 files changed, 8 insertions(+), 1 deletion(-) diff --git a/opcodes/ChangeLog b/opcodes/ChangeLog index 9e41bc5..fdb78af 100644 --- a/opcodes/ChangeLog +++ b/opcodes/ChangeLog @@ -1,3 +1,7 @@ +2016-08-30 Cupertino Miranda + + * opcodes/arc-dis.c (print_insn_arc): Changed. + 2016-08-26 Jose E. Marchesi * sparc-opc.c (sparc_opcodes): Fix typo in opcode, camellia_fi -> diff --git a/opcodes/arc-dis.c b/opcodes/arc-dis.c index 73d648d..d69a01e 100644 --- a/opcodes/arc-dis.c +++ b/opcodes/arc-dis.c @@ -938,7 +938,10 @@ print_insn_arc (bfd_vma memaddr, case bfd_mach_arc_arcv2: default: isa_mask = ARC_OPCODE_ARCv2EM; - if ((header->e_flags & EF_ARC_MACH_MSK) == EF_ARC_CPU_ARCV2HS) + /* TODO: Perhaps remove defitinion of header since it is only used at + this location. */ + if (header != NULL + && (header->e_flags & EF_ARC_MACH_MSK) == EF_ARC_CPU_ARCV2HS) { isa_mask = ARC_OPCODE_ARCv2HS; /* FPU instructions are not extensions for HS. */ -- 2.7.4