From 7753828bef7d8a96e40086b7925352923ed08b50 Mon Sep 17 00:00:00 2001 From: "morrita@google.com" Date: Fri, 27 Jan 2012 22:40:53 +0000 Subject: [PATCH] [JSC] Some JS_EXPORTDATA may not be necessary. https://bugs.webkit.org/show_bug.cgi?id=77145 Reviewed by Darin Adler. Removed JS_EXPORTDATA attributes whose attributing symbols are not exported on Mac port. * runtime/ExceptionHelpers.h: (InterruptedExecutionError): * runtime/JSBoundFunction.h: (JSBoundFunction): * runtime/RegExp.h: (RegExp): * runtime/RegExpMatchesArray.h: (RegExpMatchesArray): git-svn-id: http://svn.webkit.org/repository/webkit/trunk@106151 268f45cc-cd09-0410-ab3c-d52691b4dbfc --- Source/JavaScriptCore/ChangeLog | 19 +++++++++++++++++++ Source/JavaScriptCore/runtime/ExceptionHelpers.h | 2 +- Source/JavaScriptCore/runtime/JSBoundFunction.h | 2 +- Source/JavaScriptCore/runtime/RegExp.h | 2 +- Source/JavaScriptCore/runtime/RegExpMatchesArray.h | 2 +- 5 files changed, 23 insertions(+), 4 deletions(-) diff --git a/Source/JavaScriptCore/ChangeLog b/Source/JavaScriptCore/ChangeLog index 13f1c43..4c121e7 100644 --- a/Source/JavaScriptCore/ChangeLog +++ b/Source/JavaScriptCore/ChangeLog @@ -1,5 +1,24 @@ 2012-01-27 MORITA Hajime + [JSC] Some JS_EXPORTDATA may not be necessary. + https://bugs.webkit.org/show_bug.cgi?id=77145 + + Reviewed by Darin Adler. + + Removed JS_EXPORTDATA attributes whose attributing symbols are + not exported on Mac port. + + * runtime/ExceptionHelpers.h: + (InterruptedExecutionError): + * runtime/JSBoundFunction.h: + (JSBoundFunction): + * runtime/RegExp.h: + (RegExp): + * runtime/RegExpMatchesArray.h: + (RegExpMatchesArray): + +2012-01-27 MORITA Hajime + [WTF] WTFString.h has some extra JS_EXPORT_PRIVATEs https://bugs.webkit.org/show_bug.cgi?id=77113 diff --git a/Source/JavaScriptCore/runtime/ExceptionHelpers.h b/Source/JavaScriptCore/runtime/ExceptionHelpers.h index 388235b..7bffd29 100644 --- a/Source/JavaScriptCore/runtime/ExceptionHelpers.h +++ b/Source/JavaScriptCore/runtime/ExceptionHelpers.h @@ -79,7 +79,7 @@ public: return Structure::create(globalData, globalObject, prototype, TypeInfo(ObjectType, StructureFlags), &s_info); } - static JS_EXPORTDATA const ClassInfo s_info; + static const ClassInfo s_info; }; class TerminatedExecutionError : public JSNonFinalObject { diff --git a/Source/JavaScriptCore/runtime/JSBoundFunction.h b/Source/JavaScriptCore/runtime/JSBoundFunction.h index c60d7db..e54d458 100644 --- a/Source/JavaScriptCore/runtime/JSBoundFunction.h +++ b/Source/JavaScriptCore/runtime/JSBoundFunction.h @@ -51,7 +51,7 @@ public: return Structure::create(globalData, globalObject, prototype, TypeInfo(JSFunctionType, StructureFlags), &s_info); } - static JS_EXPORTDATA const ClassInfo s_info; + static const ClassInfo s_info; protected: const static unsigned StructureFlags = OverridesHasInstance | OverridesVisitChildren | Base::StructureFlags; diff --git a/Source/JavaScriptCore/runtime/RegExp.h b/Source/JavaScriptCore/runtime/RegExp.h index 311bb75..d0201cb 100644 --- a/Source/JavaScriptCore/runtime/RegExp.h +++ b/Source/JavaScriptCore/runtime/RegExp.h @@ -72,7 +72,7 @@ namespace JSC { return Structure::create(globalData, globalObject, prototype, TypeInfo(LeafType, 0), &s_info); } - static JS_EXPORTDATA const ClassInfo s_info; + static const ClassInfo s_info; RegExpKey key() { return RegExpKey(m_flags, m_patternString); } diff --git a/Source/JavaScriptCore/runtime/RegExpMatchesArray.h b/Source/JavaScriptCore/runtime/RegExpMatchesArray.h index acd2317..c34920d 100644 --- a/Source/JavaScriptCore/runtime/RegExpMatchesArray.h +++ b/Source/JavaScriptCore/runtime/RegExpMatchesArray.h @@ -39,7 +39,7 @@ namespace JSC { } static void destroy(JSCell*); - static JS_EXPORTDATA const ClassInfo s_info; + static const ClassInfo s_info; static Structure* createStructure(JSGlobalData& globalData, JSGlobalObject* globalObject, JSValue prototype) { -- 2.7.4