From 76f195cdbda3a76783861f28bfcf05f8cda71cee Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Wed, 11 Jul 2018 12:37:12 +0000 Subject: [PATCH] [NFC][InstCombine] Tests for x & (-1 >> y) == x -> x u<= (-1 >> y) fold https://bugs.llvm.org/show_bug.cgi?id=38123 This pattern will be produced by Implicit Integer Truncation sanitizer, https://reviews.llvm.org/D48958 https://bugs.llvm.org/show_bug.cgi?id=21530 in unsigned case, therefore it is probably a good idea to improve it. https://rise4fun.com/Alive/Rny llvm-svn: 336796 --- ...onstant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll | 137 ++++++++++++++++ ...icalize-low-bit-mask-and-icmp-eq-to-icmp-ule.ll | 177 +++++++++++++++++++++ 2 files changed, 314 insertions(+) create mode 100644 llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll create mode 100644 llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-and-icmp-eq-to-icmp-ule.ll diff --git a/llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll b/llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll new file mode 100644 index 0000000..d4ae89c --- /dev/null +++ b/llvm/test/Transforms/InstCombine/canonicalize-constant-low-bit-mask-and-icmp-eq-to-icmp-ule.ll @@ -0,0 +1,137 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -instcombine -S | FileCheck %s + +; https://bugs.llvm.org/show_bug.cgi?id=38123 + +; Pattern: +; x & C == x +; Should be transformed into: +; x u<= C +; Iff: isPowerOf2(C + 1) + +; ============================================================================ ; +; Basic positive tests +; ============================================================================ ; + +define i1 @p0(i8 %x) { +; CHECK-LABEL: @p0( +; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 3 +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP0]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = and i8 %x, 3 + %ret = icmp eq i8 %tmp0, %x + ret i1 %ret +} + +; ============================================================================ ; +; Vector tests +; ============================================================================ ; + +define <2 x i1> @p1_vec_splat(<2 x i8> %x) { +; CHECK-LABEL: @p1_vec_splat( +; CHECK-NEXT: [[TMP0:%.*]] = and <2 x i8> [[X:%.*]], +; CHECK-NEXT: [[RET:%.*]] = icmp eq <2 x i8> [[TMP0]], [[X]] +; CHECK-NEXT: ret <2 x i1> [[RET]] +; + %tmp0 = and <2 x i8> %x, + %ret = icmp eq <2 x i8> %tmp0, %x + ret <2 x i1> %ret +} + +define <2 x i1> @p2_vec_nonsplat(<2 x i8> %x) { +; CHECK-LABEL: @p2_vec_nonsplat( +; CHECK-NEXT: [[TMP0:%.*]] = and <2 x i8> [[X:%.*]], +; CHECK-NEXT: [[RET:%.*]] = icmp eq <2 x i8> [[TMP0]], [[X]] +; CHECK-NEXT: ret <2 x i1> [[RET]] +; + %tmp0 = and <2 x i8> %x, ; doesn't have to be splat. + %ret = icmp eq <2 x i8> %tmp0, %x + ret <2 x i1> %ret +} + +define <3 x i1> @p3_vec_splat_undef(<3 x i8> %x) { +; CHECK-LABEL: @p3_vec_splat_undef( +; CHECK-NEXT: [[TMP0:%.*]] = and <3 x i8> [[X:%.*]], +; CHECK-NEXT: [[RET:%.*]] = icmp eq <3 x i8> [[TMP0]], [[X]] +; CHECK-NEXT: ret <3 x i1> [[RET]] +; + %tmp0 = and <3 x i8> %x, + %ret = icmp eq <3 x i8> %tmp0, %x + ret <3 x i1> %ret +} + +; ============================================================================ ; +; Commutativity tests. +; ============================================================================ ; + +declare i8 @gen8() + +define i1 @c0() { +; CHECK-LABEL: @c0( +; CHECK-NEXT: [[X:%.*]] = call i8 @gen8() +; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X]], 3 +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[X]], [[TMP0]] +; CHECK-NEXT: ret i1 [[RET]] +; + %x = call i8 @gen8() + %tmp0 = and i8 %x, 3 + %ret = icmp eq i8 %x, %tmp0 ; swapped order + ret i1 %ret +} + +; ============================================================================ ; +; One-use tests. We don't care about multi-uses here. +; ============================================================================ ; + +declare void @use8(i8) + +define i1 @oneuse0(i8 %x) { +; CHECK-LABEL: @oneuse0( +; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 3 +; CHECK-NEXT: call void @use8(i8 [[TMP0]]) +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP0]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = and i8 %x, 3 + call void @use8(i8 %tmp0) + %ret = icmp eq i8 %tmp0, %x + ret i1 %ret +} + +; ============================================================================ ; +; Negative tests +; ============================================================================ ; + +define i1 @n0(i8 %x) { +; CHECK-LABEL: @n0( +; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 4 +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP0]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = and i8 %x, 4 ; power-of-two, but invalid. + %ret = icmp eq i8 %tmp0, %x + ret i1 %ret +} + +define i1 @n1(i8 %x, i8 %y, i8 %notx) { +; CHECK-LABEL: @n1( +; CHECK-NEXT: [[TMP0:%.*]] = and i8 [[X:%.*]], 3 +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP0]], [[NOTX:%.*]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = and i8 %x, 3 + %ret = icmp eq i8 %tmp0, %notx ; not %x + ret i1 %ret +} + +define <2 x i1> @n2(<2 x i8> %x) { +; CHECK-LABEL: @n2( +; CHECK-NEXT: [[TMP0:%.*]] = and <2 x i8> [[X:%.*]], +; CHECK-NEXT: [[RET:%.*]] = icmp eq <2 x i8> [[TMP0]], [[X]] +; CHECK-NEXT: ret <2 x i1> [[RET]] +; + %tmp0 = and <2 x i8> %x, ; only the first one is valid. + %ret = icmp eq <2 x i8> %tmp0, %x + ret <2 x i1> %ret +} diff --git a/llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-and-icmp-eq-to-icmp-ule.ll b/llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-and-icmp-eq-to-icmp-ule.ll new file mode 100644 index 0000000..ca769b9 --- /dev/null +++ b/llvm/test/Transforms/InstCombine/canonicalize-low-bit-mask-and-icmp-eq-to-icmp-ule.ll @@ -0,0 +1,177 @@ +; NOTE: Assertions have been autogenerated by utils/update_test_checks.py +; RUN: opt < %s -instcombine -S | FileCheck %s + +; https://bugs.llvm.org/show_bug.cgi?id=38123 + +; Pattern: +; x & (-1 >> y) == x +; Should be transformed into: +; x u<= (-1 >> y) + +; ============================================================================ ; +; Basic positive tests +; ============================================================================ ; + +define i1 @p0(i8 %x, i8 %y) { +; CHECK-LABEL: @p0( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X:%.*]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %tmp1 = and i8 %tmp0, %x + %ret = icmp eq i8 %tmp1, %x + ret i1 %ret +} + +; ============================================================================ ; +; Vector tests +; ============================================================================ ; + +define <2 x i1> @p1_vec(<2 x i8> %x, <2 x i8> %y) { +; CHECK-LABEL: @p1_vec( +; CHECK-NEXT: [[TMP0:%.*]] = lshr <2 x i8> , [[Y:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = and <2 x i8> [[TMP0]], [[X:%.*]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq <2 x i8> [[TMP1]], [[X]] +; CHECK-NEXT: ret <2 x i1> [[RET]] +; + %tmp0 = lshr <2 x i8> , %y + %tmp1 = and <2 x i8> %tmp0, %x + %ret = icmp eq <2 x i8> %tmp1, %x + ret <2 x i1> %ret +} + +define <3 x i1> @p2_vec_undef(<3 x i8> %x, <3 x i8> %y) { +; CHECK-LABEL: @p2_vec_undef( +; CHECK-NEXT: [[TMP0:%.*]] = lshr <3 x i8> , [[Y:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = and <3 x i8> [[TMP0]], [[X:%.*]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq <3 x i8> [[TMP1]], [[X]] +; CHECK-NEXT: ret <3 x i1> [[RET]] +; + %tmp0 = lshr <3 x i8> , %y + %tmp1 = and <3 x i8> %tmp0, %x + %ret = icmp eq <3 x i8> %tmp1, %x + ret <3 x i1> %ret +} + +; ============================================================================ ; +; Commutativity tests. +; ============================================================================ ; + +declare i8 @gen8() + +define i1 @c0(i8 %y) { +; CHECK-LABEL: @c0( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[X:%.*]] = call i8 @gen8() +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[X]], [[TMP0]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %x = call i8 @gen8() + %tmp1 = and i8 %x, %tmp0 ; swapped order + %ret = icmp eq i8 %tmp1, %x + ret i1 %ret +} + +define i1 @c1(i8 %y) { +; CHECK-LABEL: @c1( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[X:%.*]] = call i8 @gen8() +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[X]], [[TMP1]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %x = call i8 @gen8() + %tmp1 = and i8 %tmp0, %x + %ret = icmp eq i8 %x, %tmp1 ; swapped order + ret i1 %ret +} + +define i1 @c2(i8 %y) { +; CHECK-LABEL: @c2( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[X:%.*]] = call i8 @gen8() +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[X]], [[TMP0]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[X]], [[TMP1]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %x = call i8 @gen8() + %tmp1 = and i8 %x, %tmp0 ; swapped order + %ret = icmp eq i8 %x, %tmp1 ; swapped order + ret i1 %ret +} + +; ============================================================================ ; +; One-use tests. We don't care about multi-uses here. +; ============================================================================ ; + +declare void @use8(i8) + +define i1 @oneuse0(i8 %x, i8 %y) { +; CHECK-LABEL: @oneuse0( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: call void @use8(i8 [[TMP0]]) +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X:%.*]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + call void @use8(i8 %tmp0) + %tmp1 = and i8 %tmp0, %x + %ret = icmp eq i8 %tmp1, %x + ret i1 %ret +} + +define i1 @oneuse1(i8 %x, i8 %y) { +; CHECK-LABEL: @oneuse1( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X:%.*]] +; CHECK-NEXT: call void @use8(i8 [[TMP1]]) +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %tmp1 = and i8 %tmp0, %x + call void @use8(i8 %tmp1) + %ret = icmp eq i8 %tmp1, %x + ret i1 %ret +} + +define i1 @oneuse2(i8 %x, i8 %y) { +; CHECK-LABEL: @oneuse2( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: call void @use8(i8 [[TMP0]]) +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X:%.*]] +; CHECK-NEXT: call void @use8(i8 [[TMP1]]) +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[X]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + call void @use8(i8 %tmp0) + %tmp1 = and i8 %tmp0, %x + call void @use8(i8 %tmp1) + %ret = icmp eq i8 %tmp1, %x + ret i1 %ret +} + +; ============================================================================ ; +; Negative tests +; ============================================================================ ; + +define i1 @n0(i8 %x, i8 %y, i8 %notx) { +; CHECK-LABEL: @n0( +; CHECK-NEXT: [[TMP0:%.*]] = lshr i8 -1, [[Y:%.*]] +; CHECK-NEXT: [[TMP1:%.*]] = and i8 [[TMP0]], [[X:%.*]] +; CHECK-NEXT: [[RET:%.*]] = icmp eq i8 [[TMP1]], [[NOTX:%.*]] +; CHECK-NEXT: ret i1 [[RET]] +; + %tmp0 = lshr i8 -1, %y + %tmp1 = and i8 %tmp0, %x + %ret = icmp eq i8 %tmp1, %notx ; not %x + ret i1 %ret +} -- 2.7.4