From 768a5175819233102d44891bd1c103af09d488a1 Mon Sep 17 00:00:00 2001 From: Jacques Pienaar Date: Tue, 10 Aug 2021 13:03:52 -0700 Subject: [PATCH] [mlir][drr] Improve error message for unexpected attribute (NFC) When using an attribute where a value is expected previously this would fail complaining about unbound symbol. Instead make error clear and mention common failure reason. --- mlir/tools/mlir-tblgen/RewriterGen.cpp | 8 ++++++++ 1 file changed, 8 insertions(+) diff --git a/mlir/tools/mlir-tblgen/RewriterGen.cpp b/mlir/tools/mlir-tblgen/RewriterGen.cpp index 5913101..0ef5a57 100644 --- a/mlir/tools/mlir-tblgen/RewriterGen.cpp +++ b/mlir/tools/mlir-tblgen/RewriterGen.cpp @@ -1295,6 +1295,14 @@ void PatternEmitter::createAggregateLocalVarsForOpArgs( childNodeNames.lookup(argIndex)); } else { DagLeaf leaf = node.getArgAsLeaf(argIndex); + if (leaf.isConstantAttr()) + // TODO: Use better location + PrintFatalError( + loc, + "attribute found where value was expected, if attempting to use " + "constant value, construct a constant op with given attribute " + "instead"); + auto symbol = symbolInfoMap.getValueAndRangeUse(node.getArgName(argIndex)); if (leaf.isNativeCodeCall()) { -- 2.7.4