From 7632a311aa88e1cd565ae6af10d70a0ccb32bc5e Mon Sep 17 00:00:00 2001 From: "mvstanton@chromium.org" Date: Wed, 17 Jul 2013 11:42:32 +0000 Subject: [PATCH] Some tests involving AllocationSites are failing in GcStress test mode. The reason is that an AllocationMemento associated with an array only lives for one gc (it is unrooted). So an excess of garbage collections in these tests cause the Memento to be lost, and expected behavior can't be guaranteed. BUG= R=hpayer@chromium.org Review URL: https://codereview.chromium.org/19544002 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@15714 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/mjsunit/array-constructor-feedback.js | 5 +++++ test/mjsunit/array-feedback.js | 5 +++++ 2 files changed, 10 insertions(+) diff --git a/test/mjsunit/array-constructor-feedback.js b/test/mjsunit/array-constructor-feedback.js index e29e769..734d510 100644 --- a/test/mjsunit/array-constructor-feedback.js +++ b/test/mjsunit/array-constructor-feedback.js @@ -35,6 +35,11 @@ // in this test case. Depending on whether smi-only arrays are actually // enabled, this test takes the appropriate code path to check smi-only arrays. +// Reset the GC stress mode to be off. Needed because AllocationMementos only +// live for one gc, so a gc that happens in certain fragile areas of the test +// can break assumptions. +%SetFlags("--gc-interval=-1") + // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8)); support_smi_only_arrays = true; diff --git a/test/mjsunit/array-feedback.js b/test/mjsunit/array-feedback.js index d1b3062..ebe1b95 100644 --- a/test/mjsunit/array-feedback.js +++ b/test/mjsunit/array-feedback.js @@ -35,6 +35,11 @@ // in this test case. Depending on whether smi-only arrays are actually // enabled, this test takes the appropriate code path to check smi-only arrays. +// Reset the GC stress mode to be off. Needed because AllocationMementos only +// live for one gc, so a gc that happens in certain fragile areas of the test +// can break assumptions. +%SetFlags("--gc-interval=-1") + // support_smi_only_arrays = %HasFastSmiElements(new Array(1,2,3,4,5,6,7,8)); support_smi_only_arrays = true; -- 2.7.4