From 75b63a5d3e4c0816b55deaf8d105d28bfebea98b Mon Sep 17 00:00:00 2001 From: Caio Oliveira Date: Wed, 7 Jun 2023 13:13:53 -0700 Subject: [PATCH] r600/sfn: Fix warning about overloads hiding virtual functions MIME-Version: 1.0 Content-Type: text/plain; charset=utf8 Content-Transfer-Encoding: 8bit Fixes multiple warnings when building with g++ 13.1.1 that look like ``` ./src/gallium/drivers/r600/sfn/sfn_scheduler.cpp:1111:9: warning: ‘virtual void r600::CheckArrayAccessVisitor::visit(const r600::InlineConstant&)’ was hidden [-Woverloaded-virtual=] 1111 | void visit(const InlineConstant& value) override {(void)value;} | ^~~~~ ../src/gallium/drivers/r600/sfn/sfn_scheduler.cpp:1125:9: note: by ‘virtual void r600::UpdateArrayWrite::visit(const r600::LocalArrayValue&)’ 1125 | void visit(const LocalArrayValue& value) override { | ^~~~~ (...) ``` What's going on here is when mixing overloading and virtual functions, compiler will warn when one of the variants is not overriden. So tell it to also use the base class definitions. Part-of: --- src/gallium/drivers/r600/sfn/sfn_scheduler.cpp | 1 + 1 file changed, 1 insertion(+) diff --git a/src/gallium/drivers/r600/sfn/sfn_scheduler.cpp b/src/gallium/drivers/r600/sfn/sfn_scheduler.cpp index 9190f51..fb85022 100644 --- a/src/gallium/drivers/r600/sfn/sfn_scheduler.cpp +++ b/src/gallium/drivers/r600/sfn/sfn_scheduler.cpp @@ -1104,6 +1104,7 @@ BlockScheduler::collect_ready_type(std::list& ready, std::list& availa class CheckArrayAccessVisitor : public ConstRegisterVisitor { public: + using ConstRegisterVisitor::visit; void visit(const Register& value) override {(void)value;} void visit(const LocalArray& value) override {(void)value;} void visit(const UniformValue& value) override {(void)value;} -- 2.7.4