From 758e9300482c1efafa1cc96d7d7ccabe018edfb7 Mon Sep 17 00:00:00 2001 From: Riku Voipio Date: Fri, 5 Feb 2010 15:52:28 +0000 Subject: [PATCH] target-arm: neon - fix VRADDHN/VRSUBHN vs VADDHN/VSUBHN The rounding/truncating options were inverted. truncating was done when rounding was meant and vice verse. Signed-off-by: Riku Voipio Acked-by: Laurent Desnogues Signed-off-by: Aurelien Jarno --- target-arm/translate.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/target-arm/translate.c b/target-arm/translate.c index ac04996..cac157d 100644 --- a/target-arm/translate.c +++ b/target-arm/translate.c @@ -5010,7 +5010,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) case 0: case 1: case 4: /* VADDL, VADDW, VADDHN, VRADDHN */ gen_neon_addl(size); break; - case 2: case 3: case 6: /* VSUBL, VSUBW, VSUBHL, VRSUBHL */ + case 2: case 3: case 6: /* VSUBL, VSUBW, VSUBHN, VRSUBHN */ gen_neon_subl(size); break; case 5: case 7: /* VABAL, VABDL */ @@ -5079,7 +5079,7 @@ static int disas_neon_data_insn(CPUState * env, DisasContext *s, uint32_t insn) } else if (op == 4 || op == 6) { /* Narrowing operation. */ tmp = new_tmp(); - if (u) { + if (!u) { switch (size) { case 0: gen_helper_neon_narrow_high_u8(tmp, cpu_V0); -- 2.7.4