From 754c0615c94bbc7f8ede78b8b16cc616104994ef Mon Sep 17 00:00:00 2001 From: Benoit Steiner Date: Wed, 21 Mar 2018 09:19:11 -0700 Subject: [PATCH] Deleted dead code and fixed compilation warnings PiperOrigin-RevId: 189918110 --- .../core/grappler/costs/op_level_cost_estimator_test.cc | 17 ----------------- .../core/grappler/optimizers/dependency_optimizer.h | 6 ++---- .../core/grappler/optimizers/function_optimizer.h | 5 +---- tensorflow/core/grappler/optimizers/layout_optimizer.cc | 4 ---- 4 files changed, 3 insertions(+), 29 deletions(-) diff --git a/tensorflow/core/grappler/costs/op_level_cost_estimator_test.cc b/tensorflow/core/grappler/costs/op_level_cost_estimator_test.cc index d5360cb..a92f230 100644 --- a/tensorflow/core/grappler/costs/op_level_cost_estimator_test.cc +++ b/tensorflow/core/grappler/costs/op_level_cost_estimator_test.cc @@ -55,23 +55,6 @@ OpContext DescribeMatMul(int m, int n, int l, int k) { return op_context; } -// Returns an OpInfo for MatMul with unknown input shapes. -OpContext DescribeMatMulUnknownShape() { - OpContext op_context; - SetCpuDevice(&op_context.op_info); - op_context.op_info.set_op("MatMul"); - - auto input = op_context.op_info.add_inputs(); - auto shape = input->mutable_shape(); - shape->set_unknown_rank(true); - - input = op_context.op_info.add_inputs(); - shape = input->mutable_shape(); - shape->set_unknown_rank(true); - - return op_context; -} - // Wrangles the minimum number of proto fields to set up an input of // arbitrary rank and type. void DescribeArbitraryRankInput(const std::vector& dims, DataType dtype, diff --git a/tensorflow/core/grappler/optimizers/dependency_optimizer.h b/tensorflow/core/grappler/optimizers/dependency_optimizer.h index 61ed154..b4db981 100644 --- a/tensorflow/core/grappler/optimizers/dependency_optimizer.h +++ b/tensorflow/core/grappler/optimizers/dependency_optimizer.h @@ -29,9 +29,8 @@ namespace grappler { // optimizations, such as removing nodes that are effectively noops. class DependencyOptimizer : public GraphOptimizer { public: - DependencyOptimizer() : opt_level_(RewriterConfig::ON) {} - explicit DependencyOptimizer(RewriterConfig::Toggle opt_level) - : opt_level_(opt_level) {} + DependencyOptimizer() {} + explicit DependencyOptimizer(RewriterConfig::Toggle opt_level) {} ~DependencyOptimizer() override {} string name() const override { return "dependency_optimizer"; }; @@ -63,7 +62,6 @@ class DependencyOptimizer : public GraphOptimizer { // Main driver of dependency optimizations. Status OptimizeDependencies(); - RewriterConfig::Toggle opt_level_; bool fetch_nodes_known_; std::unordered_set nodes_to_preserve_; std::unique_ptr node_map_; diff --git a/tensorflow/core/grappler/optimizers/function_optimizer.h b/tensorflow/core/grappler/optimizers/function_optimizer.h index b124efe..41444e4 100644 --- a/tensorflow/core/grappler/optimizers/function_optimizer.h +++ b/tensorflow/core/grappler/optimizers/function_optimizer.h @@ -26,7 +26,7 @@ namespace grappler { // operations to make the overall graph more efficient. class FunctionOptimizer : public GraphOptimizer { public: - FunctionOptimizer(RewriterConfig::Toggle opt_level) : opt_level_(opt_level) {} + FunctionOptimizer(RewriterConfig::Toggle opt_level) {} ~FunctionOptimizer() override {} string name() const override { return "function_optimizer"; }; @@ -36,9 +36,6 @@ class FunctionOptimizer : public GraphOptimizer { void Feedback(Cluster* cluster, const GrapplerItem& item, const GraphDef& optimized_graph, double result) override; - - private: - RewriterConfig::Toggle opt_level_; }; } // end namespace grappler diff --git a/tensorflow/core/grappler/optimizers/layout_optimizer.cc b/tensorflow/core/grappler/optimizers/layout_optimizer.cc index e4af71c..18e63f8 100644 --- a/tensorflow/core/grappler/optimizers/layout_optimizer.cc +++ b/tensorflow/core/grappler/optimizers/layout_optimizer.cc @@ -301,10 +301,6 @@ bool IsComparisonOp(const NodeDef& node) { return is_compare; } -bool IsLogicalOp(const NodeDef& node) { - return IsLogicalAnd(node) || IsLogicalNot(node) || IsLogicalOr(node); -} - bool IsReduceOp(const NodeDef& node) { return IsSum(node) || IsMean(node) || IsProd(node) || IsMax(node) || IsMin(node) || IsAll(node) || IsAny(node); -- 2.7.4