From 753f74e6ff8bf4a14f099382f467a89a37ddda5e Mon Sep 17 00:00:00 2001 From: YoungHun Kim Date: Thu, 13 Apr 2023 15:21:39 +0900 Subject: [PATCH] Fix coverity issue of OVERRUN and UNUSED_VALUE Change-Id: I62c2a7a4c46bd5fb77fef1b89dd7731ea2013c05 --- core/src/muse_core.c | 11 +++++++++-- packaging/mused.spec | 2 +- server/src/muse_server_ipc.c | 1 - 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/core/src/muse_core.c b/core/src/muse_core.c index af4ae9a..2cd55da 100644 --- a/core/src/muse_core.c +++ b/core/src/muse_core.c @@ -132,8 +132,15 @@ out: static gboolean _muse_msg_is_mem_ptr_valid(gpointer ptr) { - size_t page_size = sysconf(_SC_PAGESIZE); - gpointer base = (gpointer)((size_t)ptr / page_size * page_size); + gpointer base; + long page_size = sysconf(_SC_PAGESIZE); + + if (page_size < 0) { + LOGE("sysconf is failed errno (%d)", errno); + return FALSE; + } + + base = (gpointer)((size_t)ptr / page_size * page_size); return msync(base, page_size, MS_ASYNC) == 0; } diff --git a/packaging/mused.spec b/packaging/mused.spec index 65ea6b8..771d87f 100644 --- a/packaging/mused.spec +++ b/packaging/mused.spec @@ -1,6 +1,6 @@ Name: mused Summary: A multimedia daemon -Version: 0.3.166 +Version: 0.3.167 Release: 0 Group: System/Libraries License: Apache-2.0 diff --git a/server/src/muse_server_ipc.c b/server/src/muse_server_ipc.c index 4967b76..18844cf 100644 --- a/server/src/muse_server_ipc.c +++ b/server/src/muse_server_ipc.c @@ -302,7 +302,6 @@ static gpointer _ms_ipc_dispatch_worker(gpointer data) } } muse_core_msg_object_free(jobj); - jobj = NULL; m->msg_offset += parse_len; parse_len = len - parse_len; } -- 2.7.4