From 75248a7adea4af7a88fefc5ee54ab2484f7f08b5 Mon Sep 17 00:00:00 2001 From: Adrian McCarthy Date: Wed, 8 Nov 2017 18:57:02 +0000 Subject: [PATCH] NFC: Rename MCSafeSEHFragment to MCSymbolIdFragment Summary: This fragment emits a symbol ID and will be useful for more than just Safe SEH tables (e.g., I plan to re-use it for Control Flow Guard tables). This is simply a rename refactor. Reviewers: rnk Subscribers: llvm-commits, hiraditya Differential Revision: https://reviews.llvm.org/D39770 llvm-svn: 317703 --- llvm/include/llvm/MC/MCFragment.h | 11 ++++++----- llvm/lib/MC/MCAssembler.cpp | 6 +++--- llvm/lib/MC/MCFragment.cpp | 10 +++++----- llvm/lib/MC/MCWinCOFFStreamer.cpp | 2 +- 4 files changed, 15 insertions(+), 14 deletions(-) diff --git a/llvm/include/llvm/MC/MCFragment.h b/llvm/include/llvm/MC/MCFragment.h index 7c66b21..3d73a02 100644 --- a/llvm/include/llvm/MC/MCFragment.h +++ b/llvm/include/llvm/MC/MCFragment.h @@ -42,7 +42,7 @@ public: FT_DwarfFrame, FT_LEB, FT_Padding, - FT_SafeSEH, + FT_SymbolId, FT_CVInlineLines, FT_CVDefRange, FT_Dummy @@ -562,12 +562,13 @@ public: } }; -class MCSafeSEHFragment : public MCFragment { +/// Represents a symbol table index fragment. +class MCSymbolIdFragment : public MCFragment { const MCSymbol *Sym; public: - MCSafeSEHFragment(const MCSymbol *Sym, MCSection *Sec = nullptr) - : MCFragment(FT_SafeSEH, false, 0, Sec), Sym(Sym) {} + MCSymbolIdFragment(const MCSymbol *Sym, MCSection *Sec = nullptr) + : MCFragment(FT_SymbolId, false, 0, Sec), Sym(Sym) {} /// \name Accessors /// @{ @@ -578,7 +579,7 @@ public: /// @} static bool classof(const MCFragment *F) { - return F->getKind() == MCFragment::FT_SafeSEH; + return F->getKind() == MCFragment::FT_SymbolId; } }; diff --git a/llvm/lib/MC/MCAssembler.cpp b/llvm/lib/MC/MCAssembler.cpp index 29b1441..9a23e61 100644 --- a/llvm/lib/MC/MCAssembler.cpp +++ b/llvm/lib/MC/MCAssembler.cpp @@ -290,7 +290,7 @@ uint64_t MCAssembler::computeFragmentSize(const MCAsmLayout &Layout, case MCFragment::FT_Padding: return cast(F).getSize(); - case MCFragment::FT_SafeSEH: + case MCFragment::FT_SymbolId: return 4; case MCFragment::FT_Align: { @@ -563,8 +563,8 @@ static void writeFragment(const MCAssembler &Asm, const MCAsmLayout &Layout, break; } - case MCFragment::FT_SafeSEH: { - const MCSafeSEHFragment &SF = cast(F); + case MCFragment::FT_SymbolId: { + const MCSymbolIdFragment &SF = cast(F); OW->write32(SF.getSymbol()->getIndex()); break; } diff --git a/llvm/lib/MC/MCFragment.cpp b/llvm/lib/MC/MCFragment.cpp index 94839de..1aed50a 100644 --- a/llvm/lib/MC/MCFragment.cpp +++ b/llvm/lib/MC/MCFragment.cpp @@ -281,8 +281,8 @@ void MCFragment::destroy() { case FT_Padding: delete cast(this); return; - case FT_SafeSEH: - delete cast(this); + case FT_SymbolId: + delete cast(this); return; case FT_CVInlineLines: delete cast(this); @@ -326,7 +326,7 @@ LLVM_DUMP_METHOD void MCFragment::dump() const { case MCFragment::FT_DwarfFrame: OS << "MCDwarfCallFrameFragment"; break; case MCFragment::FT_LEB: OS << "MCLEBFragment"; break; case MCFragment::FT_Padding: OS << "MCPaddingFragment"; break; - case MCFragment::FT_SafeSEH: OS << "MCSafeSEHFragment"; break; + case MCFragment::FT_SymbolId: OS << "MCSymbolIdFragment"; break; case MCFragment::FT_CVInlineLines: OS << "MCCVInlineLineTableFragment"; break; case MCFragment::FT_CVDefRange: OS << "MCCVDefRangeTableFragment"; break; case MCFragment::FT_Dummy: OS << "MCDummyFragment"; break; @@ -436,8 +436,8 @@ LLVM_DUMP_METHOD void MCFragment::dump() const { OS << "\n "; break; } - case MCFragment::FT_SafeSEH: { - const MCSafeSEHFragment *F = cast(this); + case MCFragment::FT_SymbolId: { + const MCSymbolIdFragment *F = cast(this); OS << "\n "; OS << " Sym:" << F->getSymbol(); break; diff --git a/llvm/lib/MC/MCWinCOFFStreamer.cpp b/llvm/lib/MC/MCWinCOFFStreamer.cpp index 7e0533b..c2583d9 100644 --- a/llvm/lib/MC/MCWinCOFFStreamer.cpp +++ b/llvm/lib/MC/MCWinCOFFStreamer.cpp @@ -182,7 +182,7 @@ void MCWinCOFFStreamer::EmitCOFFSafeSEH(MCSymbol const *Symbol) { if (SXData->getAlignment() < 4) SXData->setAlignment(4); - new MCSafeSEHFragment(Symbol, SXData); + new MCSymbolIdFragment(Symbol, SXData); getAssembler().registerSymbol(*Symbol); CSymbol->setIsSafeSEH(); -- 2.7.4