From 74ffa566739c7e98568a9aa8b5ab8d8f3730d30d Mon Sep 17 00:00:00 2001 From: "H.J. Lu" Date: Thu, 12 Oct 2017 14:41:22 -0700 Subject: [PATCH] Add a compile-time test for PR ld/22263 This compile-time test requires a target C compiler to run. It fails on many targets where ELF backend linkers incorrectly check bfd_link_pic for TLS relocations, which should check bfd_link_executable instead. PR ld/22263 * testsuite/ld-elf/pr22263-1.rd: New file. * testsuite/ld-elf/pr22263-1a.c: Likewise. * testsuite/ld-elf/pr22263-1b.c: Likewise. * testsuite/ld-elf/tls.exp: Likewise. --- ld/ChangeLog | 8 +++++++ ld/testsuite/ld-elf/pr22263-1.rd | 2 ++ ld/testsuite/ld-elf/pr22263-1a.c | 7 ++++++ ld/testsuite/ld-elf/pr22263-1b.c | 12 ++++++++++ ld/testsuite/ld-elf/tls.exp | 51 ++++++++++++++++++++++++++++++++++++++++ 5 files changed, 80 insertions(+) create mode 100644 ld/testsuite/ld-elf/pr22263-1.rd create mode 100644 ld/testsuite/ld-elf/pr22263-1a.c create mode 100644 ld/testsuite/ld-elf/pr22263-1b.c create mode 100644 ld/testsuite/ld-elf/tls.exp diff --git a/ld/ChangeLog b/ld/ChangeLog index 85353b6..b0f7cd2 100644 --- a/ld/ChangeLog +++ b/ld/ChangeLog @@ -1,3 +1,11 @@ +2017-10-12 H.J. Lu + + PR ld/22263 + * testsuite/ld-elf/pr22263-1.rd: New file. + * testsuite/ld-elf/pr22263-1a.c: Likewise. + * testsuite/ld-elf/pr22263-1b.c: Likewise. + * testsuite/ld-elf/tls.exp: Likewise. + 2017-10-12 Nick Clifton * testsuite/ld-aarch64/pcrel_pic_defined.d: Expect errors not diff --git a/ld/testsuite/ld-elf/pr22263-1.rd b/ld/testsuite/ld-elf/pr22263-1.rd new file mode 100644 index 0000000..9a583fb --- /dev/null +++ b/ld/testsuite/ld-elf/pr22263-1.rd @@ -0,0 +1,2 @@ + +There are no relocations in this file. diff --git a/ld/testsuite/ld-elf/pr22263-1a.c b/ld/testsuite/ld-elf/pr22263-1a.c new file mode 100644 index 0000000..ca4b75d --- /dev/null +++ b/ld/testsuite/ld-elf/pr22263-1a.c @@ -0,0 +1,7 @@ +__thread int * foo; + +void +bar (void) +{ + *foo = 1; +} diff --git a/ld/testsuite/ld-elf/pr22263-1b.c b/ld/testsuite/ld-elf/pr22263-1b.c new file mode 100644 index 0000000..ef67f32 --- /dev/null +++ b/ld/testsuite/ld-elf/pr22263-1b.c @@ -0,0 +1,12 @@ +extern __thread int *foo; + +static int x; + +extern void bar (void); + +int +_start () +{ + foo = &x; + return 0; +} diff --git a/ld/testsuite/ld-elf/tls.exp b/ld/testsuite/ld-elf/tls.exp new file mode 100644 index 0000000..9d64d6c --- /dev/null +++ b/ld/testsuite/ld-elf/tls.exp @@ -0,0 +1,51 @@ +# Expect script for TLS tests. +# Copyright (C) 2017 Free Software Foundation, Inc. +# +# This file is part of the GNU Binutils. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program; if not, write to the Free Software +# Foundation, Inc., 51 Franklin Street - Fifth Floor, Boston, +# MA 02110-1301, USA. +# + +# Make sure that binutils can correctly handle TLS. + +if { ![istarget *-*-linux*] + && ![istarget *-*-nacl*] + && ![istarget *-*-gnu*] } { + return +} + +if { [istarget *-*-linux*aout*] + || [istarget *-*-linux*oldld*] } { + return +} + +# Check to see if the C compiler works. +if { [which $CC] == 0 } { + return +} + +run_ld_link_tests [list \ + [list \ + "Build pr22263-1" \ + "-pie -e _start" \ + "" \ + "" \ + { pr22263-1a.c pr22263-1b.c } \ + {{readelf -r pr22263-1.rd}} \ + "pr22263-1" \ + "-fPIE -O2" \ + ] \ +] -- 2.7.4