From 748687fc30001b3bca0218ae909ee31f75f24e00 Mon Sep 17 00:00:00 2001 From: Jan Schmidt Date: Tue, 3 Jan 2017 02:13:30 +1100 Subject: [PATCH] queue: Don't generate GST_FLOW_ERROR without logging At least log a message to the debug log when generating a GST_FLOW_ERROR, to make it possible to find where it came from. --- plugins/elements/gstqueue.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/plugins/elements/gstqueue.c b/plugins/elements/gstqueue.c index c6d66eb..57c5759 100644 --- a/plugins/elements/gstqueue.c +++ b/plugins/elements/gstqueue.c @@ -1004,8 +1004,10 @@ gst_queue_handle_sink_event (GstPad * pad, GstObject * parent, GstEvent * event) } break; } - if (ret == FALSE) + if (ret == FALSE) { + GST_ERROR_OBJECT (queue, "Failed to push event"); return GST_FLOW_ERROR; + } return GST_FLOW_OK; /* ERRORS */ @@ -1456,7 +1458,7 @@ next: /* ERRORS */ no_item: { - GST_CAT_LOG_OBJECT (queue_dataflow, queue, + GST_CAT_ERROR_OBJECT (queue_dataflow, queue, "exit because we have no item in the queue"); return GST_FLOW_ERROR; } -- 2.7.4