From 744c58d71b21475d2edd5b9334e277cfa4c53260 Mon Sep 17 00:00:00 2001 From: Vincent Penquerc'h Date: Wed, 9 Apr 2014 11:15:10 +0100 Subject: [PATCH] speed: make duration query able to convert bytes to time It was only querying in time, but then trying to use dead bytes to time conversion code. Coverity 1139677 --- gst/speed/gstspeed.c | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/gst/speed/gstspeed.c b/gst/speed/gstspeed.c index 374ef5f..7afae38 100644 --- a/gst/speed/gstspeed.c +++ b/gst/speed/gstspeed.c @@ -324,8 +324,12 @@ speed_src_query (GstPad * pad, GstObject * parent, GstQuery * query) gst_query_set_duration (query, GST_FORMAT_TIME, -1); if (!gst_pad_peer_query_duration (filter->sinkpad, rformat, &end)) { - GST_LOG_OBJECT (filter, "query on peer pad failed"); - goto error; + GST_LOG_OBJECT (filter, "TIME query on peer pad failed, trying BYTES"); + rformat = GST_FORMAT_BYTES; + if (!gst_pad_peer_query_duration (filter->sinkpad, rformat, &end)) { + GST_LOG_OBJECT (filter, "BYTES query on peer pad failed too"); + goto error; + } } if (rformat == GST_FORMAT_BYTES) -- 2.7.4