From 742deb2495c1f409e2765cc62200eac31f1b1612 Mon Sep 17 00:00:00 2001
From: Matt Arsenault <Matthew.Arsenault@amd.com>
Date: Fri, 18 Nov 2016 04:42:57 +0000
Subject: [PATCH] AMDGPU: Fix crash on illegal type for inlineasm

There are still crashes on non-MVT types in other
places.

llvm-svn: 287310
---
 llvm/lib/Target/AMDGPU/SIISelLowering.cpp          |  2 +
 llvm/test/CodeGen/AMDGPU/inlineasm-illegal-type.ll | 83 ++++++++++++++++++++++
 2 files changed, 85 insertions(+)
 create mode 100644 llvm/test/CodeGen/AMDGPU/inlineasm-illegal-type.ll

diff --git a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
index 79953b7..61f1927 100644
--- a/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
+++ b/llvm/lib/Target/AMDGPU/SIISelLowering.cpp
@@ -4172,6 +4172,8 @@ std::pair<unsigned, const TargetRegisterClass *>
 SITargetLowering::getRegForInlineAsmConstraint(const TargetRegisterInfo *TRI,
                                                StringRef Constraint,
                                                MVT VT) const {
+  if (!isTypeLegal(VT))
+    return TargetLowering::getRegForInlineAsmConstraint(TRI, Constraint, VT);
 
   if (Constraint.size() == 1) {
     switch (Constraint[0]) {
diff --git a/llvm/test/CodeGen/AMDGPU/inlineasm-illegal-type.ll b/llvm/test/CodeGen/AMDGPU/inlineasm-illegal-type.ll
new file mode 100644
index 0000000..2eb21f0
--- /dev/null
+++ b/llvm/test/CodeGen/AMDGPU/inlineasm-illegal-type.ll
@@ -0,0 +1,83 @@
+; RUN: not llc -march=amdgcn -mcpu=bonaire -verify-machineinstrs < %s 2>&1 | FileCheck -check-prefix=GCN -check-prefix=CI %s
+; RUN: not llc -march=amdgcn -mcpu=tonga -verify-machineinstrs < %s 2>&1 | FileCheck -check-prefix=GCN -check-prefix=VI %s
+
+; GCN: error: couldn't allocate output register for constraint 's'
+; GCN: error: couldn't allocate input reg for constraint 's'
+define void @s_input_output_i8() {
+  %v = tail call i8 asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(i8 %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 'v'
+; GCN: error: couldn't allocate input reg for constraint 'v'
+define void @v_input_output_i8() {
+  %v = tail call i8 asm sideeffect "v_mov_b32 $0, -1", "=v"()
+  tail call void asm sideeffect "; use $0", "v"(i8 %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 's'
+; GCN: error: couldn't allocate input reg for constraint 's'
+define void @s_input_output_i128() {
+  %v = tail call i128 asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(i128 %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 's'
+; GCN: error: couldn't allocate input reg for constraint 's'
+define void @s_input_output_v8f16() {
+  %v = tail call <8 x half> asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(<8 x half> %v)
+  ret void
+}
+
+; CI: error: couldn't allocate output register for constraint 's'
+; CI: error: couldn't allocate input reg for constraint 's'
+; VI-NOT: error
+define void @s_input_output_f16() {
+  %v = tail call half asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(half %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 's'
+; GCN: error: couldn't allocate input reg for constraint 's'
+define void @s_input_output_v2f16() {
+  %v = tail call <2 x half> asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(<2 x half> %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 'v'
+; GCN: error: couldn't allocate input reg for constraint 'v'
+define void @v_input_output_v2f16() {
+  %v = tail call <2 x half> asm sideeffect "v_mov_b32 $0, -1", "=v"()
+  tail call void asm sideeffect "; use $0", "v"(<2 x half> %v)
+  ret void
+}
+
+; CI: error: couldn't allocate output register for constraint 's'
+; CI: error: couldn't allocate input reg for constraint 's'
+; VI-NOT: error
+define void @s_input_output_i16() {
+  %v = tail call i16 asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(i16 %v)
+  ret void
+}
+
+; GCN: error: couldn't allocate output register for constraint 's'
+; GCN: error: couldn't allocate input reg for constraint 's'
+define void @s_input_output_v2i16() {
+  %v = tail call <2 x i16> asm sideeffect "s_mov_b32 $0, -1", "=s"()
+  tail call void asm sideeffect "; use $0", "s"(<2 x i16> %v)
+  ret void
+}
+
+; FIXME: Crash in codegen prepare
+; define void @s_input_output_i3() {
+;   %v = tail call i3 asm sideeffect "s_mov_b32 $0, -1", "=s"()
+;   tail call void asm sideeffect "; use $0", "s"(i3 %v)
+;   ret void
+; }
-- 
2.7.4