From 737ffd8d7c1e7a3a7d67a237b7bde566e071c2f2 Mon Sep 17 00:00:00 2001 From: Kevin Sawicki Date: Thu, 17 Mar 2016 13:34:30 -0700 Subject: [PATCH] Improve deprecated message on webPreferences options --- lib/browser/api/browser-window.js | 2 +- spec/api-browser-window-spec.js | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/lib/browser/api/browser-window.js b/lib/browser/api/browser-window.js index fe9d441..87077ff 100644 --- a/lib/browser/api/browser-window.js +++ b/lib/browser/api/browser-window.js @@ -280,7 +280,7 @@ const checkForDeprecatedOptions = function(options) { } if (webPreferenceOption) { try { - deprecate.log(`Setting ${webPreferenceOption} on options is deprecated. Set it on options.webPreferences instead.`); + deprecate.log(`options.${webPreferenceOption} is deprecated. Use options.webPreferences.${webPreferenceOption} instead.`); } catch (error) { // Return error message so it can be rethrown via C++ return error.message; diff --git a/spec/api-browser-window-spec.js b/spec/api-browser-window-spec.js index 00bc2fb..beb84a8 100644 --- a/spec/api-browser-window-spec.js +++ b/spec/api-browser-window-spec.js @@ -776,7 +776,7 @@ describe('browser-window module', function() { it('throws a deprecation error for option keys that should be set on webPreferences', function() { assert.throws(function () { new BrowserWindow({zoomFactor: 1}); - }, 'Setting zoomFactor on options is deprecated. Set it on options.webPreferences instead.'); + }, 'options.zoomFactor is deprecated. Use options.webPreferences.zoomFactor instead.'); }); }); }); -- 2.7.4