From 7365ec2ff4a7028503f39655bd2628d54418106c Mon Sep 17 00:00:00 2001 From: Joel Brobecker Date: Thu, 4 Jan 2018 04:40:17 -0500 Subject: [PATCH] gdb.ada/maint_with_ada.exp: New testcase This commit adds a new testcase testing the "check-psymtabs" and "check-symtabs" maintenance commands. The "maintenance check-psymtabs" commands is currently known to produce some errors. While the situation was admetedly made worse by the following patch... commit b5ec771e60c1a0863e51eb491c85c674097e9e13 Date: Wed Nov 8 14:22:32 2017 +0000 Subject: Introduce lookup_name_info and generalize Ada's FULL/WILD name matching ... hence the reference to PR gdb/22670, the command was already spotting one inconsistency prior to it: (gdb) maintenance check-psymtabs Global symbol `interfaces__cS' only found in /[...]/b~var_arr_typedef.adb psymtab For now, the "check-psymtab" test is KFAIL-ed. gdb/testsuite/ChangeLog: PR gdb/22670 * gdb.ada/maint_with_ada: New testcase. Tested on x86_64-linux. --- gdb/testsuite/ChangeLog | 5 +++ gdb/testsuite/gdb.ada/maint_with_ada.exp | 38 ++++++++++++++++++++++ gdb/testsuite/gdb.ada/maint_with_ada/pack.adb | 25 ++++++++++++++ gdb/testsuite/gdb.ada/maint_with_ada/pack.ads | 29 +++++++++++++++++ .../gdb.ada/maint_with_ada/var_arr_typedef.adb | 28 ++++++++++++++++ 5 files changed, 125 insertions(+) create mode 100644 gdb/testsuite/gdb.ada/maint_with_ada.exp create mode 100644 gdb/testsuite/gdb.ada/maint_with_ada/pack.adb create mode 100644 gdb/testsuite/gdb.ada/maint_with_ada/pack.ads create mode 100644 gdb/testsuite/gdb.ada/maint_with_ada/var_arr_typedef.adb diff --git a/gdb/testsuite/ChangeLog b/gdb/testsuite/ChangeLog index c3b38c4..ea9d65c 100644 --- a/gdb/testsuite/ChangeLog +++ b/gdb/testsuite/ChangeLog @@ -1,6 +1,11 @@ 2018-01-04 Joel Brobecker PR gdb/22670 + * gdb.ada/maint_with_ada: New testcase. + +2018-01-04 Joel Brobecker + + PR gdb/22670 * gdb.ada/bp_c_mixed_case: New testcase. 2018-01-04 Joel Brobecker diff --git a/gdb/testsuite/gdb.ada/maint_with_ada.exp b/gdb/testsuite/gdb.ada/maint_with_ada.exp new file mode 100644 index 0000000..73da613 --- /dev/null +++ b/gdb/testsuite/gdb.ada/maint_with_ada.exp @@ -0,0 +1,38 @@ +# Copyright 2015-2017 Free Software Foundation, Inc. +# +# This program is free software; you can redistribute it and/or modify +# it under the terms of the GNU General Public License as published by +# the Free Software Foundation; either version 3 of the License, or +# (at your option) any later version. +# +# This program is distributed in the hope that it will be useful, +# but WITHOUT ANY WARRANTY; without even the implied warranty of +# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +# GNU General Public License for more details. +# +# You should have received a copy of the GNU General Public License +# along with this program. If not, see . + +load_lib "ada.exp" + +standard_ada_testfile var_arr_typedef + +if {[gdb_compile_ada "${srcfile}" "${binfile}" executable [list debug ]] != "" } { + return -1 +} + +clean_restart ${testfile} + +# Insert a breakpoint in each compilation unit, to force their psymtab's +# expansion to a full symtab. This will allow the check-psymtabs command +# to perform a more extensive check regarding those units which are in +# Ada. + +gdb_breakpoint "adainit" +gdb_breakpoint "Var_Arr_Typedef" +gdb_breakpoint "Do_Nothing" + +setup_kfail gdb/22670 "*-*-*" +gdb_test_no_output "maintenance check-psymtabs" + +gdb_test_no_output "maintenance check-symtabs" diff --git a/gdb/testsuite/gdb.ada/maint_with_ada/pack.adb b/gdb/testsuite/gdb.ada/maint_with_ada/pack.adb new file mode 100644 index 0000000..dc6c732 --- /dev/null +++ b/gdb/testsuite/gdb.ada/maint_with_ada/pack.adb @@ -0,0 +1,25 @@ +-- Copyright 2015-2017 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +package body Pack is + + function Identity (I : Integer) return Integer is + begin + return I; + end Identity; + + procedure Do_Nothing (A : Array_Type) is null; + +end Pack; diff --git a/gdb/testsuite/gdb.ada/maint_with_ada/pack.ads b/gdb/testsuite/gdb.ada/maint_with_ada/pack.ads new file mode 100644 index 0000000..efd73a4 --- /dev/null +++ b/gdb/testsuite/gdb.ada/maint_with_ada/pack.ads @@ -0,0 +1,29 @@ +-- Copyright 2015-2017 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +package Pack is + type Rec_Type is record + I : Integer; + B : Boolean; + end record; + + type Vec_Type is array (1 .. 4) of Rec_Type; + + type Array_Type is array (Positive range <>) of Vec_Type; + + procedure Do_Nothing (A : Array_Type); + function Identity (I : Integer) return Integer; + +end Pack; diff --git a/gdb/testsuite/gdb.ada/maint_with_ada/var_arr_typedef.adb b/gdb/testsuite/gdb.ada/maint_with_ada/var_arr_typedef.adb new file mode 100644 index 0000000..224e78f --- /dev/null +++ b/gdb/testsuite/gdb.ada/maint_with_ada/var_arr_typedef.adb @@ -0,0 +1,28 @@ +-- Copyright 2015-2017 Free Software Foundation, Inc. +-- +-- This program is free software; you can redistribute it and/or modify +-- it under the terms of the GNU General Public License as published by +-- the Free Software Foundation; either version 3 of the License, or +-- (at your option) any later version. +-- +-- This program is distributed in the hope that it will be useful, +-- but WITHOUT ANY WARRANTY; without even the implied warranty of +-- MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +-- GNU General Public License for more details. +-- +-- You should have received a copy of the GNU General Public License +-- along with this program. If not, see . + +with Pack; use Pack; + +procedure Var_Arr_Typedef is + RA : constant Rec_Type := (3, False); + RB : constant Rec_Type := (2, True); + + VA : constant Vec_Type := (RA, RA, RB, RB); + VB : constant Vec_Type := (RB, RB, RA, RA); + + A : constant Array_Type (1 .. Identity (4)) := (VA, VA, VB, VB); +begin + Do_Nothing (A); -- BREAK +end Var_Arr_Typedef; -- 2.7.4