From 72e717ca2ec06a95194711f7dd144a5b38b85bec Mon Sep 17 00:00:00 2001 From: Mike Danes Date: Sat, 17 Dec 2016 19:47:17 +0200 Subject: [PATCH] Remove unused GTF_RELOP_SMALL Commit migrated from https://github.com/dotnet/coreclr/commit/187b9b7249881b13cd8807def27c10012238b9aa --- src/coreclr/src/jit/codegenxarch.cpp | 13 +------------ src/coreclr/src/jit/compiler.cpp | 4 ---- src/coreclr/src/jit/gentree.cpp | 6 ------ src/coreclr/src/jit/gentree.h | 2 -- 4 files changed, 1 insertion(+), 24 deletions(-) diff --git a/src/coreclr/src/jit/codegenxarch.cpp b/src/coreclr/src/jit/codegenxarch.cpp index 6dcf57c..af004c8 100644 --- a/src/coreclr/src/jit/codegenxarch.cpp +++ b/src/coreclr/src/jit/codegenxarch.cpp @@ -6169,19 +6169,8 @@ void CodeGen::genCompareInt(GenTreePtr treeNode) } else // Here we know that (op1Type != op2Type) { - // Do we have a short compare against a constant in op2? - // - // We checked for this case in TreeNodeInfoInitCmp() and if we can perform a small - // compare immediate we labeled this compare with a GTF_RELOP_SMALL - // and for unsigned small non-equality compares the GTF_UNSIGNED flag. - // - if (op2->isContainedIntOrIImmed() && ((tree->gtFlags & GTF_RELOP_SMALL) != 0)) - { - assert(varTypeIsSmall(op1Type)); - cmpType = op1Type; - } #ifdef _TARGET_AMD64_ - else // compare two different sized operands + // compare two different sized operands { // For this case we don't want any memory operands, only registers or immediates // diff --git a/src/coreclr/src/jit/compiler.cpp b/src/coreclr/src/jit/compiler.cpp index 1f4fd32..8693bab 100644 --- a/src/coreclr/src/jit/compiler.cpp +++ b/src/coreclr/src/jit/compiler.cpp @@ -9163,10 +9163,6 @@ int cTreeFlagsIR(Compiler* comp, GenTree* tree) { chars += printf("[RELOP_QMARK]"); } - if (tree->gtFlags & GTF_RELOP_SMALL) - { - chars += printf("[RELOP_SMALL]"); - } break; case GT_QMARK: diff --git a/src/coreclr/src/jit/gentree.cpp b/src/coreclr/src/jit/gentree.cpp index cd48165..fa75f5b 100644 --- a/src/coreclr/src/jit/gentree.cpp +++ b/src/coreclr/src/jit/gentree.cpp @@ -10277,12 +10277,6 @@ void Compiler::gtDispNode(GenTreePtr tree, IndentStack* indentStack, __in __in_z --msgLength; break; } - if (tree->gtFlags & GTF_RELOP_SMALL) - { - printf("S"); - --msgLength; - break; - } goto DASH; default: diff --git a/src/coreclr/src/jit/gentree.h b/src/coreclr/src/jit/gentree.h index b0ee600..f11458c 100644 --- a/src/coreclr/src/jit/gentree.h +++ b/src/coreclr/src/jit/gentree.h @@ -908,8 +908,6 @@ public: #define GTF_RELOP_NAN_UN 0x80000000 // GT_ -- Is branch taken if ops are NaN? #define GTF_RELOP_JMP_USED 0x40000000 // GT_ -- result of compare used for jump or ?: #define GTF_RELOP_QMARK 0x20000000 // GT_ -- the node is the condition for ?: -#define GTF_RELOP_SMALL 0x10000000 // GT_ -- We should use a byte or short sized compare (op1->gtType - // is the small type) #define GTF_RELOP_ZTT 0x08000000 // GT_ -- Loop test cloned for converting while-loops into do-while // with explicit "loop test" in the header block. -- 2.7.4