From 72b86ae8686932832d57bc6f6e45645f9c2d8243 Mon Sep 17 00:00:00 2001 From: Vineeth TM Date: Wed, 29 Jul 2015 13:43:50 +0900 Subject: [PATCH] matroska: fix memory leak After adding to tag list, key_val is not being free'd resulting in memory leak https://bugzilla.gnome.org/show_bug.cgi?id=752992 --- gst/matroska/matroska-read-common.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/gst/matroska/matroska-read-common.c b/gst/matroska/matroska-read-common.c index 5718086..6076e40 100644 --- a/gst/matroska/matroska-read-common.c +++ b/gst/matroska/matroska-read-common.c @@ -2034,6 +2034,7 @@ gst_matroska_read_common_parse_metadata_id_simple_tag (GstMatroskaReadCommon * key_val = g_strdup_printf ("%s=%s", name_with_parent, value); gst_tag_list_add (*p_taglist, GST_TAG_MERGE_APPEND, GST_TAG_EXTENDED_COMMENT, key_val, NULL); + g_free (key_val); } else if (tag && value && *value != '\0') { gboolean matched = FALSE; guint i; @@ -2078,6 +2079,7 @@ gst_matroska_read_common_parse_metadata_id_simple_tag (GstMatroskaReadCommon * key_val = g_strdup_printf ("%s=%s", tag, value); gst_tag_list_add (*p_taglist, GST_TAG_MERGE_APPEND, GST_TAG_EXTENDED_COMMENT, key_val, NULL); + g_free (key_val); } } -- 2.7.4