From 72a731e270f8d123131f7463d7372f38144c19a3 Mon Sep 17 00:00:00 2001 From: Davis Goodin Date: Tue, 23 Jan 2018 14:10:49 -0600 Subject: [PATCH] Never attempt Portable PDB conversion The inline script detected whether the branch name contained "release/" and ran a different target. That target tries to convert Portable PDBs into Windows PDBs, which currently hits errors in CoreCLR. Remove this logic from CoreCLR: it is no longer necessary because orchestrated builds will have a post-build symbol publish step. --- buildpipeline/DotNet-Trusted-Publish-Symbols.json | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/buildpipeline/DotNet-Trusted-Publish-Symbols.json b/buildpipeline/DotNet-Trusted-Publish-Symbols.json index 879f71e..617fff0 100644 --- a/buildpipeline/DotNet-Trusted-Publish-Symbols.json +++ b/buildpipeline/DotNet-Trusted-Publish-Symbols.json @@ -42,7 +42,7 @@ "enabled": true, "continueOnError": false, "alwaysRun": false, - "displayName": "Extract symbol packages; if release branch, archive", + "displayName": "Extract symbol packages", "timeoutInMinutes": 0, "task": { "id": "e213ff0f-5d5c-4791-802d-52ea3e7be1f1", @@ -54,7 +54,7 @@ "scriptName": "", "arguments": "-BuildType $(PB_BuildType) -SymPkgGlob $(PB_AzureContainerSymbolPackageGlob) -Branch $(SourceBranch)", "workingFolder": "$(Pipeline.SourcesDirectory)", - "inlineScript": "param($BuildType, $SymPkgGlob, $Branch)\nif ($BuildType -ne \"Release\") { exit }\n$archive = $Branch.StartsWith(\"release/\")\n\n$target = \"UnzipSymbolPackagesForPublish\"\nif ($archive) { $target = \"SubmitSymbolsRequest\" }\n\n.\\run.cmd build -- `\n/t:$target `\n/p:SymbolPackagesToPublishGlob=$SymPkgGlob `\n/p:ArchiveSymbols=$archive `\n/p:SkipCreateWindowsPdbsFromPortablePdbs=true `\n/v:D", + "inlineScript": "param($BuildType, $SymPkgGlob, $Branch)\nif ($BuildType -ne \"Release\") { exit }\n\n.\\run.cmd build -- `\n/t:UnzipSymbolPackagesForPublish `\n/p:SymbolPackagesToPublishGlob=$SymPkgGlob `\n/v:D", "failOnStandardError": "true" } }, -- 2.7.4