From 71fc0026b0dd3b8c4766935b65bdd889c7acaab3 Mon Sep 17 00:00:00 2001 From: Eunhae Choi Date: Wed, 14 Mar 2018 19:02:19 +0900 Subject: [PATCH] [0.6.98] fix coverity issue Change-Id: Idd76c326895176c0c91630c4321964a212527347 --- packaging/libmm-player.spec | 2 +- src/mm_player_priv.c | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/packaging/libmm-player.spec b/packaging/libmm-player.spec index 31f65a5..5ef15f8 100644 --- a/packaging/libmm-player.spec +++ b/packaging/libmm-player.spec @@ -1,6 +1,6 @@ Name: libmm-player Summary: Multimedia Framework Player Library -Version: 0.6.97 +Version: 0.6.98 Release: 0 Group: Multimedia/Libraries License: Apache-2.0 diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 56b6850..5658983 100755 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -5218,7 +5218,7 @@ __mmplayer_video_stream_decoded_render_cb(GstElement* object, GstBuffer *buffer, int i = 0; /* copy pointer of tbm bo, stride, elevation */ - while (video_buffer->handle.bo[i] && i < MM_VIDEO_BUFFER_PLANE_MAX) { + while (i < MM_VIDEO_BUFFER_PLANE_MAX && video_buffer->handle.bo[i]) { stream->bo[i] = tbm_bo_ref(video_buffer->handle.bo[i]); i++; } @@ -5361,7 +5361,7 @@ static int __mmplayer_gst_create_video_filters(mm_player_t* player, GList** bucket) { gchar* video_csc = "videoconvert"; /* default colorspace converter */ - GList* element_bucket = *bucket; + GList* element_bucket = NULL; MMPLAYER_RETURN_VAL_IF_FAIL(player && player->pipeline && player->pipeline->videobin, MM_ERROR_PLAYER_NOT_INITIALIZED); @@ -5385,6 +5385,8 @@ __mmplayer_gst_create_video_filters(mm_player_t* player, GList** bucket) return MM_ERROR_NONE; ERROR: /* refer MMPLAYER_CREATE_ELEMENT */ + g_list_free(element_bucket); + *bucket = NULL; MMPLAYER_FLEAVE(); return MM_ERROR_PLAYER_INTERNAL; -- 2.34.1