From 71c4b8dfe1dd7c20242d303cd33cc022b7af9331 Mon Sep 17 00:00:00 2001 From: Fangrui Song Date: Sat, 26 Feb 2022 04:41:49 +0000 Subject: [PATCH] [crt][test] Add -no-pie to avoid wacky linking with crt1.o if (musl || CLANG_DEFAULT_PIE_ON_LINUX) This works with glibc crt1.o (its crt1.o is essentially Scrt1.o plus (if static PIE is supported for the arch) _dl_relocate_static_pie) but looks wacky. musl crt1.o is not built with an explicit -fno-pic/-fpie/-fpic. If it was built with a non-default-pie GCC/Clang, the linker might complain about absolute relocations referencing _init/_fini for the -pie link: ``` ld: error: relocation R_X86_64_32 cannot be used against symbol '_fini'; recompile with -fPIC >>> defined in obj/crt/crt1.o >>> referenced by crt1.c >>> obj/crt/crt1.o:(_start_c) ``` --- compiler-rt/test/crt/ctor_dtor.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/compiler-rt/test/crt/ctor_dtor.c b/compiler-rt/test/crt/ctor_dtor.c index 90be0b4..2bea050 100644 --- a/compiler-rt/test/crt/ctor_dtor.c +++ b/compiler-rt/test/crt/ctor_dtor.c @@ -1,5 +1,5 @@ // RUN: %clang -fno-use-init-array -g -c %s -o %t.o -// RUN: %clang -fno-use-init-array -g -o %t -nostdlib %crt1 %crti %crtbegin %t.o -lc %libgcc %crtend %crtn +// RUN: %clang -o %t -no-pie -nostdlib %crt1 %crti %crtbegin %t.o -lc %libgcc %crtend %crtn // RUN: %run %t 2>&1 | FileCheck %s #include -- 2.7.4