From 7141596fae74938c907209482a46ecb73df1d4f8 Mon Sep 17 00:00:00 2001 From: Simon Hausmann Date: Wed, 20 Jul 2011 10:50:21 +0200 Subject: [PATCH] Fix memory leaks with QV8Engine's ExtensionData The destructor has to be virtual for Deletable in order to call the destructor of the super-class. Change-Id: I3aeebe28c0a6bbfbbe3b069e88a6096dd9e173f5 Reviewed-on: http://codereview.qt.nokia.com/1867 Reviewed-by: Qt Sanity Bot Reviewed-by: Aaron Kennedy --- src/declarative/qml/v8/qv8engine_p.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/declarative/qml/v8/qv8engine_p.h b/src/declarative/qml/v8/qv8engine_p.h index 6c05fe4..d9f4fee 100644 --- a/src/declarative/qml/v8/qv8engine_p.h +++ b/src/declarative/qml/v8/qv8engine_p.h @@ -213,7 +213,7 @@ public: ~QV8Engine(); struct Deletable { - ~Deletable() {} + virtual ~Deletable() {} }; void init(QDeclarativeEngine *); -- 2.7.4