From 7035cbf8ebf2acb00cd17fd8c2004d8d884cfb37 Mon Sep 17 00:00:00 2001 From: Benjamin Kramer Date: Thu, 21 Jul 2016 14:13:45 +0000 Subject: [PATCH] [clang-tidy] Avoid duplicated DenseMap lookup. The std::string is still constructed on demand. No functionality change intended. llvm-svn: 276282 --- clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp index d0a7e5f..619c0c1 100644 --- a/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp +++ b/clang-tools-extra/clang-tidy/ClangTidyDiagnosticConsumer.cpp @@ -176,8 +176,7 @@ DiagnosticBuilder ClangTidyContext::diag( assert(Loc.isValid()); unsigned ID = DiagEngine->getDiagnosticIDs()->getCustomDiagID( Level, (Description + " [" + CheckName + "]").str()); - if (CheckNamesByDiagnosticID.count(ID) == 0) - CheckNamesByDiagnosticID.insert(std::make_pair(ID, CheckName.str())); + CheckNamesByDiagnosticID.try_emplace(ID, CheckName); return DiagEngine->Report(Loc, ID); } -- 2.7.4