From 702411fc298032a2e700907cc3d6136d5b46afe7 Mon Sep 17 00:00:00 2001 From: Louis Dionne Date: Thu, 14 Mar 2019 17:15:47 +0000 Subject: [PATCH] [libc++][CMake] Do not define `cxx_shared_EXPORTS` when building the shared library CMake will define -Dcxx_shared_EXPORTS when building the shared library by default. In theory, this is used to signal to the library that we're building a shared library and that dllimport/dllexport should be used. However, we already have our own way of doing that, so I'm removing this define to avoid meaningless command line arguments in the build. llvm-svn: 356167 --- libcxx/lib/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/libcxx/lib/CMakeLists.txt b/libcxx/lib/CMakeLists.txt index 91924f4..fd493d4 100644 --- a/libcxx/lib/CMakeLists.txt +++ b/libcxx/lib/CMakeLists.txt @@ -207,6 +207,7 @@ if (LIBCXX_ENABLE_SHARED) OUTPUT_NAME "c++" VERSION "${LIBCXX_ABI_VERSION}.0" SOVERSION "${LIBCXX_ABI_VERSION}" + DEFINE_SYMBOL "" ) cxx_set_common_defines(cxx_shared) -- 2.7.4