From 6f5ed57683fdfe41d0a60ad15fc01cfccac07797 Mon Sep 17 00:00:00 2001 From: "kmillikin@chromium.org" Date: Thu, 15 Oct 2009 15:01:36 +0000 Subject: [PATCH] Untangle some #include dependencies. "jsregexp.h" and "jump-target.h" required "macro-assembler.h" to always be included first. Instead the include of "macro-assembler.h" has moved into those header files. "dateparser-inl.h" required "dateparser.h" to always be included first. Instead the include of "dateparser.h" has moved into "dateparser-inl.h". Review URL: http://codereview.chromium.org/267117 git-svn-id: http://v8.googlecode.com/svn/branches/bleeding_edge@3074 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- src/ast.h | 5 ++--- src/dateparser-inl.h | 2 ++ src/jsregexp.cc | 3 --- src/jsregexp.h | 2 ++ src/jump-target.h | 2 ++ src/objects-debug.cc | 1 - src/runtime.cc | 5 ++--- 7 files changed, 10 insertions(+), 10 deletions(-) diff --git a/src/ast.h b/src/ast.h index 6eacd06..4222216 100644 --- a/src/ast.h +++ b/src/ast.h @@ -30,12 +30,11 @@ #include "execution.h" #include "factory.h" +#include "jsregexp.h" +#include "jump-target.h" #include "runtime.h" #include "token.h" #include "variables.h" -#include "macro-assembler.h" -#include "jsregexp.h" -#include "jump-target.h" namespace v8 { namespace internal { diff --git a/src/dateparser-inl.h b/src/dateparser-inl.h index 3d4161d..d5921d5 100644 --- a/src/dateparser-inl.h +++ b/src/dateparser-inl.h @@ -28,6 +28,8 @@ #ifndef V8_DATEPARSER_INL_H_ #define V8_DATEPARSER_INL_H_ +#include "dateparser.h" + namespace v8 { namespace internal { diff --git a/src/jsregexp.cc b/src/jsregexp.cc index e518662..c77f32d 100644 --- a/src/jsregexp.cc +++ b/src/jsregexp.cc @@ -45,13 +45,10 @@ #ifdef V8_NATIVE_REGEXP #if V8_TARGET_ARCH_IA32 -#include "ia32/macro-assembler-ia32.h" #include "ia32/regexp-macro-assembler-ia32.h" #elif V8_TARGET_ARCH_X64 -#include "x64/macro-assembler-x64.h" #include "x64/regexp-macro-assembler-x64.h" #elif V8_TARGET_ARCH_ARM -#include "arm/macro-assembler-arm.h" #include "arm/regexp-macro-assembler-arm.h" #else #error Unsupported target architecture. diff --git a/src/jsregexp.h b/src/jsregexp.h index 3bc30b6..84f8d98 100644 --- a/src/jsregexp.h +++ b/src/jsregexp.h @@ -28,6 +28,8 @@ #ifndef V8_JSREGEXP_H_ #define V8_JSREGEXP_H_ +#include "macro-assembler.h" + namespace v8 { namespace internal { diff --git a/src/jump-target.h b/src/jump-target.h index 0c42f1b..0933ee7 100644 --- a/src/jump-target.h +++ b/src/jump-target.h @@ -28,6 +28,8 @@ #ifndef V8_JUMP_TARGET_H_ #define V8_JUMP_TARGET_H_ +#include "macro-assembler.h" + namespace v8 { namespace internal { diff --git a/src/objects-debug.cc b/src/objects-debug.cc index 288cc21..afa51f6 100644 --- a/src/objects-debug.cc +++ b/src/objects-debug.cc @@ -29,7 +29,6 @@ #include "disassembler.h" #include "disasm.h" -#include "macro-assembler.h" #include "jsregexp.h" namespace v8 { diff --git a/src/runtime.cc b/src/runtime.cc index a2a8193..9eeffd1 100644 --- a/src/runtime.cc +++ b/src/runtime.cc @@ -34,18 +34,17 @@ #include "arguments.h" #include "compiler.h" #include "cpu.h" -#include "dateparser.h" #include "dateparser-inl.h" #include "debug.h" #include "execution.h" #include "jsregexp.h" +#include "parser.h" #include "platform.h" #include "runtime.h" #include "scopeinfo.h" -#include "v8threads.h" #include "smart-pointer.h" -#include "parser.h" #include "stub-cache.h" +#include "v8threads.h" namespace v8 { namespace internal { -- 2.7.4