From 6eb910a59c05b694166cf082634ee0ad35da4079 Mon Sep 17 00:00:00 2001 From: Alex Torres Date: Tue, 3 Sep 2019 11:12:25 -0700 Subject: [PATCH] Remove unused variables Remove unused variables and attributes from BaseViewConversionHelper on mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp Closes tensorflow/mlir#116 COPYBARA_INTEGRATE_REVIEW=https://github.com/tensorflow/mlir/pull/116 from alexst07:fix-warnings 5f638e4677492cf71a9cc040eeb6b57427d32e06 PiperOrigin-RevId: 266972082 --- .../Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp | 20 +++++++------------- 1 file changed, 7 insertions(+), 13 deletions(-) diff --git a/mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp b/mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp index 3c4123e..e29827e 100644 --- a/mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp +++ b/mlir/lib/Dialect/Linalg/Transforms/LowerToLLVMDialect.cpp @@ -185,20 +185,19 @@ public: BaseViewConversionHelper(Operation *op, ViewType viewType, ConversionPatternRewriter &rewriter, LLVMTypeConverter &lowering) - : indexType(rewriter.getIndexType()), viewType(viewType), - elementTy(getPtrToElementType(viewType, lowering)), + : elementTy(getPtrToElementType(viewType, lowering)), int64Ty( lowering.convertType(rewriter.getIntegerType(64)).cast()), - viewDescriptorPtrTy( - convertLinalgType(viewType, lowering).cast()), rewriter(rewriter) { - + IndexType indexType = rewriter.getIndexType(); + viewDescriptorPtrTy = + convertLinalgType(viewType, lowering).cast(); OpBuilder::InsertionGuard insertGuard(rewriter); rewriter.setInsertionPointToStart( &op->getParentOfType().getBlocks().front()); edsc::ScopedContext context(rewriter, op->getLoc()); - one = constant(int64Ty, IntegerAttr::get(indexType, 1)); + Value *one = constant(int64Ty, IntegerAttr::get(indexType, 1)); // Alloca with proper alignment. allocatedDesc = llvm_alloca(viewDescriptorPtrTy, one, /*alignment=*/8); // Load the alloca'ed descriptor. @@ -209,11 +208,9 @@ public: return positionAttr(rewriter, values); }; - IndexType indexType; - ViewType viewType; LLVMType elementTy, int64Ty, viewDescriptorPtrTy; ConversionPatternRewriter &rewriter; - Value *one, *allocatedDesc, *desc; + Value *allocatedDesc, *desc; }; } // namespace @@ -594,10 +591,7 @@ public: auto tranposeOp = cast(op); BaseViewConversionHelper helper(op, tranposeOp.getViewType(), rewriter, lowering); - IndexType indexType = helper.indexType; - ViewType viewType = helper.viewType; - LLVMType elementTy = helper.elementTy, int64Ty = helper.int64Ty, - viewDescriptorPtrTy = helper.viewDescriptorPtrTy; + LLVMType elementTy = helper.elementTy, int64Ty = helper.int64Ty; Value *allocatedDesc = helper.allocatedDesc, *desc = helper.desc; edsc::ScopedContext context(rewriter, op->getLoc()); -- 2.7.4