From 6eb38f9b3ef636570df2415bae1d568c9c650023 Mon Sep 17 00:00:00 2001 From: =?utf8?q?Tim-Philipp=20M=C3=BCller?= Date: Sun, 27 Apr 2014 00:49:01 +0100 Subject: [PATCH] giobasesink: we mustn't change the format of a query response Not even in the DEFAULT case. That's bad 0.10 behaviour, no caller is ever going to check the format of the response. --- gst/gio/gstgiobasesink.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/gst/gio/gstgiobasesink.c b/gst/gio/gstgiobasesink.c index 8a34b70..d50e8aa 100644 --- a/gst/gio/gstgiobasesink.c +++ b/gst/gio/gstgiobasesink.c @@ -325,7 +325,7 @@ gst_gio_base_sink_query (GstBaseSink * bsink, GstQuery * query) switch (format) { case GST_FORMAT_BYTES: case GST_FORMAT_DEFAULT: - gst_query_set_position (query, GST_FORMAT_BYTES, sink->position); + gst_query_set_position (query, format, sink->position); return TRUE; default: return FALSE; @@ -346,7 +346,7 @@ gst_gio_base_sink_query (GstBaseSink * bsink, GstQuery * query) case GST_QUERY_SEEKING: gst_query_parse_seeking (query, &format, NULL, NULL, NULL); if (format == GST_FORMAT_BYTES || format == GST_FORMAT_DEFAULT) { - gst_query_set_seeking (query, GST_FORMAT_BYTES, + gst_query_set_seeking (query, format, GST_GIO_STREAM_IS_SEEKABLE (sink->stream), 0, -1); } else { gst_query_set_seeking (query, format, FALSE, 0, -1); -- 2.7.4