From 6eabd678ad9a1f4b3c112b9b0441a95cb8d204af Mon Sep 17 00:00:00 2001
From: Feng Jin <feng16.jin@samsung.com>
Date: Sat, 3 Jun 2017 22:13:18 +0800
Subject: [PATCH] Hide Size, and use Size2D instead.

Change-Id: Ic6d08de968c3fa6fbee0df74555e3cabb500a201
Signed-off-by: Feng Jin <feng16.jin@samsung.com>
---
 Tizen.NUI/Tizen.NUI.csproj                        | 48 +++++++++--------------
 Tizen.NUI/src/{public => internal}/Size.cs        |  2 +-
 Tizen.NUI/src/internal/ViewWrapperImpl.cs         |  4 +-
 Tizen.NUI/src/public/BaseComponents/CustomView.cs |  4 +-
 Tizen.NUI/src/public/BaseComponents/View.cs       | 29 +++-----------
 Tizen.NUI/src/public/CustomView/Spin.cs           |  4 +-
 Tizen.NUI/src/public/Property.cs                  | 20 ----------
 Tizen.NUI/src/public/Size2D.cs                    |  9 -----
 8 files changed, 31 insertions(+), 89 deletions(-)
 rename Tizen.NUI/src/{public => internal}/Size.cs (99%)
 mode change 100644 => 100755 Tizen.NUI/src/public/BaseComponents/CustomView.cs

diff --git a/Tizen.NUI/Tizen.NUI.csproj b/Tizen.NUI/Tizen.NUI.csproj
index 55f6438..74346a4 100755
--- a/Tizen.NUI/Tizen.NUI.csproj
+++ b/Tizen.NUI/Tizen.NUI.csproj
@@ -50,10 +50,8 @@
     <Compile Include="src\internal\AccessibilityFocusOvershotSignal.cs" />
     <Compile Include="src\internal\AccessibilityManager.cs" />
     <Compile Include="src\internal\Alignment.cs" />
-    <Compile Include="src\internal\AlignType.cs" />
     <Compile Include="src\internal\AngleAxis.cs" />
     <Compile Include="src\internal\AngleThresholdPair.cs" />
-    <Compile Include="src\internal\Animatable.cs" />
     <Compile Include="src\internal\AnimatablePropertyComponentRegistration.cs" />
     <Compile Include="src\internal\AnimatablePropertyRegistration.cs" />
     <Compile Include="src\internal\AnimationSignal.cs" />
@@ -63,23 +61,18 @@
     <Compile Include="src\internal\ApplicationExtensions.cs" />
     <Compile Include="src\internal\ApplicationSignal.cs" />
     <Compile Include="src\internal\AsyncImageLoader.cs" />
-    <Compile Include="src\internal\BaseHandle.cs" />
     <Compile Include="src\internal\BaseObject.cs" />
     <Compile Include="src\internal\BlendEquationType.cs" />
     <Compile Include="src\internal\BlendFactorType.cs" />
     <Compile Include="src\internal\BlendModeType.cs" />
     <Compile Include="src\internal\BufferImage.cs" />
     <Compile Include="src\internal\Builder.cs" />
-    <Compile Include="src\internal\Button.cs" />
     <Compile Include="src\internal\ButtonSignal.cs" />
     <Compile Include="src\internal\Camera.cs" />
     <Compile Include="src\internal\ChildPropertyRegistration.cs" />
-    <Compile Include="src\internal\ClampState.cs" />
-    <Compile Include="src\internal\ClampState2D.cs" />
     <Compile Include="src\internal\ConnectionTracker.cs" />
     <Compile Include="src\internal\ConnectionTrackerInterface.cs" />
     <Compile Include="src\internal\ControlKeySignal.cs" />
-    <Compile Include="src\internal\ControlOrientationType.cs" />
     <Compile Include="src\internal\CustomActor.cs" />
     <Compile Include="src\internal\CustomActorImpl.cs" />
     <Compile Include="src\internal\CustomAlgorithmInterface.cs" />
@@ -92,7 +85,6 @@
     <Compile Include="src\internal\DepthFunctionType.cs" />
     <Compile Include="src\internal\DepthTestModeType.cs" />
     <Compile Include="src\internal\DepthWriteModeType.cs" />
-    <Compile Include="src\internal\DirectionBias.cs" />
     <Compile Include="src\internal\DirectionType.cs" />
     <Compile Include="src\internal\DisposeQueue.cs" />
     <Compile Include="src\internal\dotnetcore\AddedException.cs" />
@@ -126,7 +118,6 @@
     <Compile Include="src\internal\ItemLayout.cs" />
     <Compile Include="src\internal\ItemRange.cs" />
     <Compile Include="src\internal\ItemView.cs" />
-    <Compile Include="src\internal\KeyboardPreFocusChangeSignal.cs" />
     <Compile Include="src\internal\KeyEventSignal.cs" />
     <Compile Include="src\internal\KeyInputFocusManager.cs" />
     <Compile Include="src\internal\KeyInputFocusSignal.cs" />
@@ -137,7 +128,6 @@
     <Compile Include="src\internal\ManualPINVOKE.cs" />
     <Compile Include="src\internal\Matrix.cs" />
     <Compile Include="src\internal\Matrix3.cs" />
-    <Compile Include="src\internal\Meta.cs" />
     <Compile Include="src\internal\Model3dView.cs" />
     <Compile Include="src\internal\NativeImage.cs" />
     <Compile Include="src\internal\NativeImageInterface.cs" />
@@ -148,7 +138,6 @@
     <Compile Include="src\internal\ObjectCreatedSignal.cs" />
     <Compile Include="src\internal\ObjectDestroyedSignal.cs" />
     <Compile Include="src\internal\ObjectRegistry.cs" />
-    <Compile Include="src\internal\PaddingType.cs" />
     <Compile Include="src\internal\PageFactory.cs" />
     <Compile Include="src\internal\PagePanSignal.cs" />
     <Compile Include="src\internal\PageTurnLandscapeView.cs" />
@@ -162,9 +151,7 @@
     <Compile Include="src\internal\PinchGestureDetector.cs" />
     <Compile Include="src\internal\PixelData.cs" />
     <Compile Include="src\internal\PixelFormat.cs" />
-    <Compile Include="src\internal\Popup.cs" />
-    <Compile Include="src\internal\PositionInheritanceMode.cs" />
-    <Compile Include="src\internal\ProgressBar.cs" />
+    <Compile Include="src\internal\PreFocusChangeSignal.cs" />
     <Compile Include="src\internal\ProgressBarValueChangedSignal.cs" />
     <Compile Include="src\internal\PropertyBuffer.cs" />
     <Compile Include="src\internal\PropertyCondition.cs" />
@@ -173,7 +160,6 @@
     <Compile Include="src\internal\PropertyRangeManager.cs" />
     <Compile Include="src\internal\PropertyRanges.cs" />
     <Compile Include="src\internal\PropertyRegistration.cs" />
-    <Compile Include="src\internal\RadioButton.cs" />
     <Compile Include="src\internal\RefObject.cs" />
     <Compile Include="src\internal\RenderBufferFormat.cs" />
     <Compile Include="src\internal\Renderer.cs" />
@@ -188,10 +174,7 @@
     <Compile Include="src\internal\RulerDomain.cs" />
     <Compile Include="src\internal\RulerPtr.cs" />
     <Compile Include="src\internal\Sampler.cs" />
-    <Compile Include="src\internal\Scrollable.cs" />
     <Compile Include="src\internal\ScrollableSignal.cs" />
-    <Compile Include="src\internal\ScrollView.cs" />
-    <Compile Include="src\internal\ScrollViewEffect.cs" />
     <Compile Include="src\internal\ScrollViewPagePathEffect.cs" />
     <Compile Include="src\internal\ScrollViewSnapStartedSignal.cs" />
     <Compile Include="src\internal\Shader.cs" />
@@ -263,17 +246,14 @@
     <Compile Include="src\internal\TextureType.cs" />
     <Compile Include="src\internal\TimePeriod.cs" />
     <Compile Include="src\internal\TimerSignalType.cs" />
-    <Compile Include="src\internal\ToggleButton.cs" />
     <Compile Include="src\internal\ToolkitPropertyRange.cs" />
     <Compile Include="src\internal\TooltipPositionType.cs" />
     <Compile Include="src\internal\TouchDataSignal.cs" />
     <Compile Include="src\internal\TouchPoint.cs" />
     <Compile Include="src\internal\TouchPointContainer.cs" />
     <Compile Include="src\internal\TouchSignal.cs" />
-    <Compile Include="src\internal\TransitionData.cs" />
     <Compile Include="src\internal\Type.cs" />
     <Compile Include="src\internal\TypeAction.cs" />
-    <Compile Include="src\internal\TypeInfo.cs" />
     <Compile Include="src\internal\TypeRegistration.cs" />
     <Compile Include="src\internal\TypeRegistry.cs" />
     <Compile Include="src\internal\Uint16Pair.cs" />
@@ -281,30 +261,28 @@
     <Compile Include="src\internal\uintp.cs" />
     <Compile Include="src\internal\ushortp.cs" />
     <Compile Include="src\internal\VectorBase.cs" />
-    <Compile Include="src\internal\VectorFloat.cs" />
-    <Compile Include="src\internal\VectorInteger.cs" />
     <Compile Include="src\internal\VectorUint16Pair.cs" />
     <Compile Include="src\internal\VectorUnsignedChar.cs" />
     <Compile Include="src\internal\VideoViewSignal.cs" />
-    <Compile Include="src\internal\ViewContainer.cs" />
     <Compile Include="src\internal\ViewImpl.cs" />
     <Compile Include="src\internal\ViewMode.cs" />
     <Compile Include="src\internal\ViewRegistry.cs" />
     <Compile Include="src\internal\ViewResourceReadySignal.cs" />
     <Compile Include="src\internal\ViewSignal.cs" />
     <Compile Include="src\internal\ViewVisibilityChangedSignal.cs" />
-    <Compile Include="src\internal\ViewWrapper.cs" />
     <Compile Include="src\internal\ViewWrapperImpl.cs" />
-    <Compile Include="src\internal\VisibilityChangeType.cs" />
-    <Compile Include="src\internal\VisualType.cs" />
     <Compile Include="src\internal\WheelSignal.cs" />
     <Compile Include="src\internal\WindowFocusSignalType.cs" />
     <Compile Include="src\internal\VoidSignal.cs" />
     <Compile Include="src\public\AlphaFunction.cs" />
+    <Compile Include="src\public\Animatable.cs" />
     <Compile Include="src\public\Animation.cs" />
+    <Compile Include="src\public\BaseComponents\VisibilityChangeType.cs" />
+    <Compile Include="src\public\BaseHandle.cs" />
     <Compile Include="src\public\Color.cs" />
     <Compile Include="src\public\CustomView\Spin.cs" />
     <Compile Include="src\public\Degree.cs" />
+    <Compile Include="src\public\DirectionBias.cs" />
     <Compile Include="src\public\FlexContainer.cs" />
     <Compile Include="src\public\FocusManager.cs" />
     <Compile Include="src\public\Gesture.cs" />
@@ -315,11 +293,13 @@
     <Compile Include="src\public\LongPressGesture.cs" />
     <Compile Include="src\public\NUIApplication.cs" />
     <Compile Include="src\public\NUIConstants.cs" />
+    <Compile Include="src\public\PaddingType.cs" />
     <Compile Include="src\public\PanGesture.cs" />
     <Compile Include="src\public\Path.cs" />
     <Compile Include="src\public\PinchGesture.cs" />
     <Compile Include="src\public\Position.cs" />
     <Compile Include="src\public\Position2D.cs" />
+    <Compile Include="src\public\ProgressBar.cs" />
     <Compile Include="src\public\Property.cs" />
     <Compile Include="src\public\Radian.cs" />
     <Compile Include="src\public\Rectangle.cs" />
@@ -328,12 +308,15 @@
     <Compile Include="src\public\RelativeVector4.cs" />
     <Compile Include="src\public\RelayoutContainer.cs" />
     <Compile Include="src\public\Rotation.cs" />
+    <Compile Include="src\public\Scrollable.cs" />
+    <Compile Include="src\public\ScrollViewEffect.cs" />
     <Compile Include="src\public\Size2D.cs" />
     <Compile Include="src\public\StyleManager.cs" />
     <Compile Include="src\public\TableView.cs" />
     <Compile Include="src\public\TapGesture.cs" />
     <Compile Include="src\public\Timer.cs" />
     <Compile Include="src\public\Touch.cs" />
+    <Compile Include="src\public\TransitionData.cs" />
     <Compile Include="src\public\TTSPlayer.cs" />
     <Compile Include="src\public\BaseComponents\ImageView.cs" />
     <Compile Include="src\public\BaseComponents\TextEditor.cs" />
@@ -342,22 +325,27 @@
     <Compile Include="src\public\BaseComponents\View.cs" />
     <Compile Include="src\public\BaseComponents\CustomView.cs" />
     <Compile Include="src\public\BaseComponents\VisualView.cs" />
+    <Compile Include="src\public\TypeInfo.cs" />
+    <Compile Include="src\public\UIComponents\Button.cs" />
     <Compile Include="src\public\UIComponents\CheckBoxButton.cs" />
+    <Compile Include="src\public\UIComponents\Popup.cs" />
     <Compile Include="src\public\UIComponents\PushButton.cs" />
+    <Compile Include="src\public\UIComponents\RadioButton.cs" />
     <Compile Include="src\public\UIComponents\ScrollBar.cs" />
+    <Compile Include="src\public\UIComponents\ScrollView.cs" />
+    <Compile Include="src\public\UIComponents\ToggleButton.cs" />
     <Compile Include="src\public\Vector2.cs" />
     <Compile Include="src\public\Vector3.cs" />
     <Compile Include="src\public\Vector4.cs" />
     <Compile Include="src\public\VideoView.cs" />
+    <Compile Include="src\public\ViewWrapper.cs" />
     <Compile Include="src\public\VisualBase.cs" />
     <Compile Include="src\public\VisualFactory.cs" />
     <Compile Include="src\public\VisualMaps.cs" />
     <Compile Include="src\public\Wheel.cs" />
     <Compile Include="src\public\Window.cs" />
   </ItemGroup>
-  <ItemGroup>
-    <Folder Include="Properties\" />
-  </ItemGroup>
+  <ItemGroup />
   <Import Project="$(MSBuildToolsPath)\Microsoft.CSharp.targets" />
   <!-- To modify your build process, add your task inside one of the targets below and uncomment it.
 		Other similar extension points exist, see Microsoft.Common.targets.
diff --git a/Tizen.NUI/src/public/Size.cs b/Tizen.NUI/src/internal/Size.cs
similarity index 99%
rename from Tizen.NUI/src/public/Size.cs
rename to Tizen.NUI/src/internal/Size.cs
index f5a3dc7..c656b01 100755
--- a/Tizen.NUI/src/public/Size.cs
+++ b/Tizen.NUI/src/internal/Size.cs
@@ -21,7 +21,7 @@ namespace Tizen.NUI
     /// <summary>
     /// Three dimensional size
     /// </summary>
-    public class Size : global::System.IDisposable
+    internal class Size : global::System.IDisposable
     {
         private global::System.Runtime.InteropServices.HandleRef swigCPtr;
         protected bool swigCMemOwn;
diff --git a/Tizen.NUI/src/internal/ViewWrapperImpl.cs b/Tizen.NUI/src/internal/ViewWrapperImpl.cs
index 14ce6ec..81489de 100755
--- a/Tizen.NUI/src/internal/ViewWrapperImpl.cs
+++ b/Tizen.NUI/src/internal/ViewWrapperImpl.cs
@@ -33,7 +33,7 @@ namespace Tizen.NUI
         public delegate bool OnWheelDelegate(Wheel wheel);
         public delegate void OnRelayoutDelegate(Vector2 size, RelayoutContainer container);
         public delegate void OnSetResizePolicyDelegate(ResizePolicyType policy, DimensionType dimension);
-        public delegate Size GetNaturalSizeDelegate();
+        public delegate Size2D GetNaturalSizeDelegate();
         public delegate float CalculateChildSizeDelegate(View child, DimensionType dimension);
         public delegate float GetHeightForWidthDelegate(float width);
         public delegate float GetWidthForHeightDelegate(float height);
@@ -365,7 +365,7 @@ namespace Tizen.NUI
 
         private global::System.IntPtr DirectorGetNaturalSize()
         {
-            return Size.getCPtr(GetNaturalSize()).Handle;
+            return Size2D.getCPtr(GetNaturalSize()).Handle;
         }
 
         private float DirectorCalculateChildSize(global::System.IntPtr child, int dimension)
diff --git a/Tizen.NUI/src/public/BaseComponents/CustomView.cs b/Tizen.NUI/src/public/BaseComponents/CustomView.cs
old mode 100644
new mode 100755
index dc92c96..5bfe0a6
--- a/Tizen.NUI/src/public/BaseComponents/CustomView.cs
+++ b/Tizen.NUI/src/public/BaseComponents/CustomView.cs
@@ -484,9 +484,9 @@ namespace Tizen.NUI.BaseComponents
         /// Return the natural size of the view.
         /// </summary>
         /// <returns>The view's natural size</returns>
-        public virtual Size GetNaturalSize()
+        public virtual Size2D GetNaturalSize()
         {
-            return new Size(0.0f, 0.0f, 0.0f);
+            return new Size2D(0, 0);
         }
 
         /// <summary>
diff --git a/Tizen.NUI/src/public/BaseComponents/View.cs b/Tizen.NUI/src/public/BaseComponents/View.cs
index 177a6d1..b61651a 100755
--- a/Tizen.NUI/src/public/BaseComponents/View.cs
+++ b/Tizen.NUI/src/public/BaseComponents/View.cs
@@ -1591,7 +1591,8 @@ namespace Tizen.NUI.BaseComponents
             {
                 Size temp = new Size(0.0f, 0.0f, 0.0f);
                 GetProperty(View.Property.SIZE).Get(temp);
-                return new Size2D(temp);
+                Size2D size = new Size2D((int)temp.Width, (int)temp.Height);
+                return size;
             }
             set
             {
@@ -1603,7 +1604,7 @@ namespace Tizen.NUI.BaseComponents
         ///  Retrieves the size of the View.<br>
         ///  The coordinates are relative to the View's parent.<br>
         /// </summary>
-        public Size CurrentSize
+        public Size2D CurrentSize
         {
             get
             {
@@ -2082,12 +2083,13 @@ namespace Tizen.NUI.BaseComponents
             return ret;
         }
 
-        internal Size GetCurrentSize()
+        internal Size2D GetCurrentSize()
         {
             Size ret = new Size(NDalicPINVOKE.Actor_GetCurrentSize(swigCPtr), true);
             if (NDalicPINVOKE.SWIGPendingException.Pending)
                 throw NDalicPINVOKE.SWIGPendingException.Retrieve();
-            return ret;
+            Size2D size = new Size2D((int)ret.Width, (int)ret.Height);
+            return size;
         }
 
         internal Vector3 GetNaturalSize()
@@ -2782,25 +2784,6 @@ namespace Tizen.NUI.BaseComponents
         }
 
         /// <summary>
-        /// Gets/Sets the size of an view.<br>
-        /// Geometry can be scaled to fit within this area.<br>
-        /// This does not interfere with the views scale factor.<br>
-        /// </summary>
-        public Size Size
-        {
-            get
-            {
-                Size temp = new Size(0.0f, 0.0f, 0.0f);
-                GetProperty(View.Property.SIZE).Get(temp);
-                return temp;
-            }
-            set
-            {
-                SetProperty(View.Property.SIZE, new Tizen.NUI.PropertyValue(value));
-            }
-        }
-
-        /// <summary>
         /// Gets/Sets the size width of an view.
         /// </summary>
         public float SizeWidth
diff --git a/Tizen.NUI/src/public/CustomView/Spin.cs b/Tizen.NUI/src/public/CustomView/Spin.cs
index 96f2d12..f9ef43e 100755
--- a/Tizen.NUI/src/public/CustomView/Spin.cs
+++ b/Tizen.NUI/src/public/CustomView/Spin.cs
@@ -118,9 +118,9 @@ namespace Tizen.NUI
         /// Return the natural size of the actor.<br>
         /// </summary>
         /// <returns> Natural size of this Spin itself</returns>
-        public override Size GetNaturalSize()
+        public override Size2D GetNaturalSize()
         {
-            return new Size(150.0f, 150.0f, 0.0f);
+            return new Size2D(150, 150);
         }
 
         /// <summary>
diff --git a/Tizen.NUI/src/public/Property.cs b/Tizen.NUI/src/public/Property.cs
index 71879cf..7f61663 100755
--- a/Tizen.NUI/src/public/Property.cs
+++ b/Tizen.NUI/src/public/Property.cs
@@ -1172,15 +1172,6 @@ namespace Tizen.NUI
         }
 
         /// <summary>
-        /// Creates a Size property value.
-        /// </summary>
-        /// <param name="vectorValue">A Size values</param>
-        public PropertyValue(Size vectorValue) : this(NDalicPINVOKE.new_Property_Value__SWIG_5(Size.getCPtr(vectorValue)), true)
-        {
-            if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve();
-        }
-
-        /// <summary>
         /// Creates a Position2D property value.
         /// </summary>
         /// <param name="vectorValue">A Position2D values</param>
@@ -1220,17 +1211,6 @@ namespace Tizen.NUI
         }
 
         /// <summary>
-        /// Retrieves a Size2D value.
-        /// </summary>
-        /// <param name="vectorValue"> On return, a Size2D value</param>
-        public bool Get(Size vectorValue)
-        {
-            bool ret = NDalicPINVOKE.Property_Value_Get__SWIG_6(swigCPtr, Size.getCPtr(vectorValue));
-            if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve();
-            return ret;
-        }
-
-        /// <summary>
         /// Retrieves a Position2D value.
         /// </summary>
         /// <param name="vectorValue"> On return, a Position2D value</param>
diff --git a/Tizen.NUI/src/public/Size2D.cs b/Tizen.NUI/src/public/Size2D.cs
index 0df0143..82235c2 100755
--- a/Tizen.NUI/src/public/Size2D.cs
+++ b/Tizen.NUI/src/public/Size2D.cs
@@ -225,15 +225,6 @@ namespace Tizen.NUI
             if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve();
         }
 
-        /// <summary>
-        /// Constructor.
-        /// </summary>
-        /// <param name="size">Size with x (width), y (height), and z (depth)</param>
-        public Size2D(Size size) : this(NDalicPINVOKE.new_Vector2__SWIG_3(Size.getCPtr(size)), true)
-        {
-            if (NDalicPINVOKE.SWIGPendingException.Pending) throw NDalicPINVOKE.SWIGPendingException.Retrieve();
-        }
-
         private Size2D Add(Size2D rhs)
         {
             Size2D ret = new Size2D(NDalicPINVOKE.Vector2_Add(swigCPtr, Size2D.getCPtr(rhs)), true);
-- 
2.7.4