From 6e7e7e0e537a063e1d318cd5aa7d846131e60ce8 Mon Sep 17 00:00:00 2001 From: Lokesh Date: Thu, 23 Jan 2020 16:14:41 +0530 Subject: [PATCH] Remove unnecessary case of SCARD_ERROR_OK for THROW_ERROR THROW_ERROR is always called if errorCode != SCARD_ERROR_OK Hence switch case of SCARD_ERROR_OK was shown redundant by coverity. Change-Id: I81a878f8c05e599068662828438201cd8d95dc9d Signed-off-by: Lokesh --- common/include/Exception.h | 8 -------- packaging/smartcard-service.spec | 2 +- 2 files changed, 1 insertion(+), 9 deletions(-) diff --git a/common/include/Exception.h b/common/include/Exception.h index 8dc9f9e..82a9f7d 100644 --- a/common/include/Exception.h +++ b/common/include/Exception.h @@ -28,10 +28,6 @@ { \ switch (errorCode) \ { \ - case SCARD_ERROR_OK : \ - /* do nothing */ \ - break; \ - \ case SCARD_ERROR_IPC_FAILED : \ case SCARD_ERROR_IO_FAILED : \ case SCARD_ERROR_OPERATION_TIMEOUT : \ @@ -225,10 +221,6 @@ namespace smartcard_service_api { switch (errorCode) { - case SCARD_ERROR_OK : - /* do nothing */ - break; - case SCARD_ERROR_IPC_FAILED : case SCARD_ERROR_IO_FAILED : case SCARD_ERROR_OPERATION_TIMEOUT : diff --git a/packaging/smartcard-service.spec b/packaging/smartcard-service.spec index d996701..3dd4ea2 100755 --- a/packaging/smartcard-service.spec +++ b/packaging/smartcard-service.spec @@ -1,6 +1,6 @@ Name: smartcard-service Summary: Smartcard Service FW -Version: 0.1.58 +Version: 0.1.59 Release: 0 Group: Network & Connectivity License: Apache-2.0 -- 2.7.4