From 6de481a3786b5b0409eddeee4b99a148e3f0f3f3 Mon Sep 17 00:00:00 2001 From: Peter Collingbourne Date: Fri, 11 Nov 2016 19:50:39 +0000 Subject: [PATCH] Bitcode: Change getModuleSummaryIndex() to return an llvm::Expected. Differential Revision: https://reviews.llvm.org/D26539 llvm-svn: 286624 --- clang/lib/CodeGen/BackendUtil.cpp | 14 ++++---- llvm/include/llvm/Bitcode/BitcodeReader.h | 8 ++--- .../llvm/Object/ModuleSummaryIndexObjectFile.h | 9 +++-- llvm/lib/Bitcode/Reader/BitcodeReader.cpp | 28 ++++----------- llvm/lib/LTO/LTO.cpp | 7 ++-- llvm/lib/LTO/ThinLTOCodeGenerator.cpp | 18 ++++------ llvm/lib/Object/ModuleSummaryIndexObjectFile.cpp | 37 ++++++++----------- llvm/lib/Transforms/IPO/FunctionImport.cpp | 41 ++++------------------ llvm/tools/llvm-link/llvm-link.cpp | 28 ++++----------- llvm/tools/llvm-lto/llvm-lto.cpp | 37 +++++++------------ 10 files changed, 66 insertions(+), 161 deletions(-) diff --git a/clang/lib/CodeGen/BackendUtil.cpp b/clang/lib/CodeGen/BackendUtil.cpp index d0bd22c..62dc95e 100644 --- a/clang/lib/CodeGen/BackendUtil.cpp +++ b/clang/lib/CodeGen/BackendUtil.cpp @@ -725,14 +725,12 @@ static void runThinLTOBackend(const CodeGenOptions &CGOpts, Module *M, // If we are performing a ThinLTO importing compile, load the function index // into memory and pass it into thinBackend, which will run the function // importer and invoke LTO passes. - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile( - CGOpts.ThinLTOIndexFile, - [&](const DiagnosticInfo &DI) { M->getContext().diagnose(DI); }); - if (std::error_code EC = IndexOrErr.getError()) { - std::string Error = EC.message(); - errs() << "Error loading index file '" << CGOpts.ThinLTOIndexFile - << "': " << Error << "\n"; + Expected> IndexOrErr = + llvm::getModuleSummaryIndexForFile(CGOpts.ThinLTOIndexFile); + if (!IndexOrErr) { + logAllUnhandledErrors(IndexOrErr.takeError(), errs(), + "Error loading index file '" + + CGOpts.ThinLTOIndexFile + "': "); return; } std::unique_ptr CombinedIndex = std::move(*IndexOrErr); diff --git a/llvm/include/llvm/Bitcode/BitcodeReader.h b/llvm/include/llvm/Bitcode/BitcodeReader.h index 25af17b..765b17d 100644 --- a/llvm/include/llvm/Bitcode/BitcodeReader.h +++ b/llvm/include/llvm/Bitcode/BitcodeReader.h @@ -32,9 +32,6 @@ namespace llvm { // Remove these functions once no longer needed by the C and libLTO APIs. std::error_code errorToErrorCodeAndEmitErrors(LLVMContext &Ctx, Error Err); - std::error_code - errorToErrorCodeAndEmitErrors(const DiagnosticHandlerFunction &DiagHandler, - Error Err); template ErrorOr expectedToErrorOrAndEmitErrors(LLVMContext &Ctx, Expected Val) { @@ -80,9 +77,8 @@ namespace llvm { Expected hasGlobalValueSummary(MemoryBufferRef Buffer); /// Parse the specified bitcode buffer, returning the module summary index. - ErrorOr> - getModuleSummaryIndex(MemoryBufferRef Buffer, - const DiagnosticHandlerFunction &DiagnosticHandler); + Expected> + getModuleSummaryIndex(MemoryBufferRef Buffer); /// isBitcodeWrapper - Return true if the given bytes are the magic bytes /// for an LLVM IR bitcode wrapper. diff --git a/llvm/include/llvm/Object/ModuleSummaryIndexObjectFile.h b/llvm/include/llvm/Object/ModuleSummaryIndexObjectFile.h index 8d30f77..7426097 100644 --- a/llvm/include/llvm/Object/ModuleSummaryIndexObjectFile.h +++ b/llvm/include/llvm/Object/ModuleSummaryIndexObjectFile.h @@ -82,16 +82,15 @@ public: /// \brief Parse module summary index in the given memory buffer. /// Return new ModuleSummaryIndexObjectFile instance containing parsed module /// summary/index. - static ErrorOr> - create(MemoryBufferRef Object, - const DiagnosticHandlerFunction &DiagnosticHandler); + static Expected> + create(MemoryBufferRef Object); }; } /// Parse the module summary index out of an IR file and return the module /// summary index object if found, or nullptr if not. -ErrorOr> getModuleSummaryIndexForFile( - StringRef Path, const DiagnosticHandlerFunction &DiagnosticHandler); +Expected> +getModuleSummaryIndexForFile(StringRef Path); } #endif diff --git a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp index 357f283..bb58674 100644 --- a/llvm/lib/Bitcode/Reader/BitcodeReader.cpp +++ b/llvm/lib/Bitcode/Reader/BitcodeReader.cpp @@ -841,19 +841,6 @@ std::error_code llvm::errorToErrorCodeAndEmitErrors(LLVMContext &Ctx, return std::error_code(); } -std::error_code llvm::errorToErrorCodeAndEmitErrors( - const DiagnosticHandlerFunction &DiagHandler, Error Err) { - if (Err) { - std::error_code EC; - handleAllErrors(std::move(Err), [&](ErrorInfoBase &EIB) { - EC = EIB.convertToErrorCode(); - DiagHandler(DiagnosticInfoInlineAsm(EIB.message())); - }); - return EC; - } - return std::error_code(); -} - BitcodeReader::BitcodeReader(BitstreamCursor Stream, LLVMContext &Context) : BitcodeReaderBase(std::move(Stream)), Context(Context), ValueList(Context), MetadataList(Context) {} @@ -6663,22 +6650,19 @@ Expected llvm::getBitcodeProducerString(MemoryBufferRef Buffer) { } // Parse the specified bitcode buffer, returning the function info index. -ErrorOr> llvm::getModuleSummaryIndex( - MemoryBufferRef Buffer, - const DiagnosticHandlerFunction &DiagnosticHandler) { +Expected> +llvm::getModuleSummaryIndex(MemoryBufferRef Buffer) { Expected StreamOrErr = initStream(Buffer); if (!StreamOrErr) - return errorToErrorCodeAndEmitErrors(DiagnosticHandler, - StreamOrErr.takeError()); + return StreamOrErr.takeError(); ModuleSummaryIndexBitcodeReader R(std::move(*StreamOrErr)); auto Index = llvm::make_unique(); - if (std::error_code EC = errorToErrorCodeAndEmitErrors( - DiagnosticHandler, - R.parseSummaryIndexInto(Index.get(), Buffer.getBufferIdentifier()))) - return EC; + if (Error Err = + R.parseSummaryIndexInto(Index.get(), Buffer.getBufferIdentifier())) + return std::move(Err); return std::move(Index); } diff --git a/llvm/lib/LTO/LTO.cpp b/llvm/lib/LTO/LTO.cpp index 4ff1bfb..cf40bfd 100644 --- a/llvm/lib/LTO/LTO.cpp +++ b/llvm/lib/LTO/LTO.cpp @@ -417,11 +417,10 @@ Error LTO::addThinLTO(std::unique_ptr Input, collectUsedGlobalVariables(M, Used, /*CompilerUsed*/ false); MemoryBufferRef MBRef = Input->Obj->getMemoryBufferRef(); - ErrorOr> - SummaryObjOrErr = - object::ModuleSummaryIndexObjectFile::create(MBRef, Conf.DiagHandler); + Expected> + SummaryObjOrErr = object::ModuleSummaryIndexObjectFile::create(MBRef); if (!SummaryObjOrErr) - return errorCodeToError(SummaryObjOrErr.getError()); + return SummaryObjOrErr.takeError(); ThinLTO.CombinedIndex.mergeFrom((*SummaryObjOrErr)->takeIndex(), ThinLTO.ModuleMap.size()); diff --git a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp index 77f1d34..86968a7 100644 --- a/llvm/lib/LTO/ThinLTOCodeGenerator.cpp +++ b/llvm/lib/LTO/ThinLTOCodeGenerator.cpp @@ -69,12 +69,6 @@ namespace { static cl::opt ThreadCount("threads", cl::init(llvm::heavyweight_hardware_concurrency())); -static void diagnosticHandler(const DiagnosticInfo &DI) { - DiagnosticPrinterRawOStream DP(errs()); - DI.print(DP); - errs() << '\n'; -} - // Simple helper to save temporary files for debug. static void saveTempBitcode(const Module &TheModule, StringRef TempDir, unsigned count, StringRef Suffix) { @@ -513,13 +507,13 @@ std::unique_ptr ThinLTOCodeGenerator::linkCombinedIndex() { std::unique_ptr CombinedIndex; uint64_t NextModuleId = 0; for (auto &ModuleBuffer : Modules) { - ErrorOr> ObjOrErr = - object::ModuleSummaryIndexObjectFile::create(ModuleBuffer, - diagnosticHandler); - if (std::error_code EC = ObjOrErr.getError()) { + Expected> ObjOrErr = + object::ModuleSummaryIndexObjectFile::create(ModuleBuffer); + if (!ObjOrErr) { // FIXME diagnose - errs() << "error: can't create ModuleSummaryIndexObjectFile for buffer: " - << EC.message() << "\n"; + logAllUnhandledErrors( + ObjOrErr.takeError(), errs(), + "error: can't create ModuleSummaryIndexObjectFile for buffer: "); return nullptr; } auto Index = (*ObjOrErr)->takeIndex(); diff --git a/llvm/lib/Object/ModuleSummaryIndexObjectFile.cpp b/llvm/lib/Object/ModuleSummaryIndexObjectFile.cpp index e597fc2..d37530b 100644 --- a/llvm/lib/Object/ModuleSummaryIndexObjectFile.cpp +++ b/llvm/lib/Object/ModuleSummaryIndexObjectFile.cpp @@ -70,44 +70,37 @@ ModuleSummaryIndexObjectFile::findBitcodeInMemBuffer(MemoryBufferRef Object) { // Parse module summary index in the given memory buffer. // Return new ModuleSummaryIndexObjectFile instance containing parsed // module summary/index. -ErrorOr> -ModuleSummaryIndexObjectFile::create( - MemoryBufferRef Object, - const DiagnosticHandlerFunction &DiagnosticHandler) { - std::unique_ptr Index; - +Expected> +ModuleSummaryIndexObjectFile::create(MemoryBufferRef Object) { ErrorOr BCOrErr = findBitcodeInMemBuffer(Object); if (!BCOrErr) - return BCOrErr.getError(); - - ErrorOr> IOrErr = - getModuleSummaryIndex(BCOrErr.get(), DiagnosticHandler); + return errorCodeToError(BCOrErr.getError()); - if (std::error_code EC = IOrErr.getError()) - return EC; + Expected> IOrErr = + getModuleSummaryIndex(BCOrErr.get()); - Index = std::move(IOrErr.get()); + if (!IOrErr) + return std::move(IOrErr.takeError()); + std::unique_ptr Index = std::move(IOrErr.get()); return llvm::make_unique(Object, std::move(Index)); } // Parse the module summary index out of an IR file and return the summary // index object if found, or nullptr if not. -ErrorOr> llvm::getModuleSummaryIndexForFile( - StringRef Path, const DiagnosticHandlerFunction &DiagnosticHandler) { +Expected> +llvm::getModuleSummaryIndexForFile(StringRef Path) { ErrorOr> FileOrErr = MemoryBuffer::getFileOrSTDIN(Path); std::error_code EC = FileOrErr.getError(); if (EC) - return EC; + return errorCodeToError(EC); MemoryBufferRef BufferRef = (FileOrErr.get())->getMemBufferRef(); - ErrorOr> ObjOrErr = - object::ModuleSummaryIndexObjectFile::create(BufferRef, - DiagnosticHandler); - EC = ObjOrErr.getError(); - if (EC) - return EC; + Expected> ObjOrErr = + object::ModuleSummaryIndexObjectFile::create(BufferRef); + if (!ObjOrErr) + return ObjOrErr.takeError(); object::ModuleSummaryIndexObjectFile &Obj = **ObjOrErr; return Obj.takeIndex(); diff --git a/llvm/lib/Transforms/IPO/FunctionImport.cpp b/llvm/lib/Transforms/IPO/FunctionImport.cpp index 8b25250..2a351b3 100644 --- a/llvm/lib/Transforms/IPO/FunctionImport.cpp +++ b/llvm/lib/Transforms/IPO/FunctionImport.cpp @@ -739,36 +739,6 @@ static cl::opt SummaryFile("summary-file", cl::desc("The summary file to use for function importing.")); -static void diagnosticHandler(const DiagnosticInfo &DI) { - raw_ostream &OS = errs(); - DiagnosticPrinterRawOStream DP(OS); - DI.print(DP); - OS << '\n'; -} - -/// Parse the summary index out of an IR file and return the summary -/// index object if found, or nullptr if not. -static std::unique_ptr getModuleSummaryIndexForFile( - StringRef Path, std::string &Error, - const DiagnosticHandlerFunction &DiagnosticHandler) { - std::unique_ptr Buffer; - ErrorOr> BufferOrErr = - MemoryBuffer::getFile(Path); - if (std::error_code EC = BufferOrErr.getError()) { - Error = EC.message(); - return nullptr; - } - Buffer = std::move(BufferOrErr.get()); - ErrorOr> ObjOrErr = - object::ModuleSummaryIndexObjectFile::create(Buffer->getMemBufferRef(), - DiagnosticHandler); - if (std::error_code EC = ObjOrErr.getError()) { - Error = EC.message(); - return nullptr; - } - return (*ObjOrErr)->takeIndex(); -} - static bool doImportingForModule(Module &M, const ModuleSummaryIndex *Index) { if (SummaryFile.empty() && !Index) report_fatal_error("error: -function-import requires -summary-file or " @@ -777,13 +747,14 @@ static bool doImportingForModule(Module &M, const ModuleSummaryIndex *Index) { if (!SummaryFile.empty()) { if (Index) report_fatal_error("error: -summary-file and index from frontend\n"); - std::string Error; - IndexPtr = - getModuleSummaryIndexForFile(SummaryFile, Error, diagnosticHandler); - if (!IndexPtr) { - errs() << "Error loading file '" << SummaryFile << "': " << Error << "\n"; + Expected> IndexPtrOrErr = + getModuleSummaryIndexForFile(SummaryFile); + if (!IndexPtrOrErr) { + logAllUnhandledErrors(IndexPtrOrErr.takeError(), errs(), + "Error loading file '" + SummaryFile + "': "); return false; } + IndexPtr = std::move(*IndexPtrOrErr); Index = IndexPtr.get(); } diff --git a/llvm/tools/llvm-link/llvm-link.cpp b/llvm/tools/llvm-link/llvm-link.cpp index f90e391..903fa12 100644 --- a/llvm/tools/llvm-link/llvm-link.cpp +++ b/llvm/tools/llvm-link/llvm-link.cpp @@ -180,7 +180,7 @@ Module &ModuleLazyLoaderCache::operator()(const char *argv0, } } // anonymous namespace -static void diagnosticHandler(const DiagnosticInfo &DI) { +static void diagnosticHandler(const DiagnosticInfo &DI, void *C) { unsigned Severity = DI.getSeverity(); switch (Severity) { case DS_Error: @@ -201,23 +201,13 @@ static void diagnosticHandler(const DiagnosticInfo &DI) { errs() << '\n'; } -static void diagnosticHandlerWithContext(const DiagnosticInfo &DI, void *C) { - diagnosticHandler(DI); -} - /// Import any functions requested via the -import option. static bool importFunctions(const char *argv0, LLVMContext &Context, Linker &L) { if (SummaryIndex.empty()) return true; - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile(SummaryIndex, diagnosticHandler); - std::error_code EC = IndexOrErr.getError(); - if (EC) { - errs() << EC.message() << '\n'; - return false; - } - auto Index = std::move(IndexOrErr.get()); + std::unique_ptr Index = + ExitOnErr(llvm::getModuleSummaryIndexForFile(SummaryIndex)); // Map of Module -> List of globals to import from the Module std::map> ModuleToGlobalsToImportMap; @@ -319,14 +309,8 @@ static bool linkFiles(const char *argv0, LLVMContext &Context, Linker &L, // If a module summary index is supplied, load it so linkInModule can treat // local functions/variables as exported and promote if necessary. if (!SummaryIndex.empty()) { - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile(SummaryIndex, diagnosticHandler); - std::error_code EC = IndexOrErr.getError(); - if (EC) { - errs() << EC.message() << '\n'; - return false; - } - auto Index = std::move(IndexOrErr.get()); + std::unique_ptr Index = + ExitOnErr(llvm::getModuleSummaryIndexForFile(SummaryIndex)); // Promotion if (renameModuleForThinLTO(*M, *Index)) @@ -353,7 +337,7 @@ int main(int argc, char **argv) { ExitOnErr.setBanner(std::string(argv[0]) + ": "); LLVMContext Context; - Context.setDiagnosticHandler(diagnosticHandlerWithContext, nullptr, true); + Context.setDiagnosticHandler(diagnosticHandler, nullptr, true); llvm_shutdown_obj Y; // Call llvm_shutdown() on exit. cl::ParseCommandLineOptions(argc, argv, "llvm linker\n"); diff --git a/llvm/tools/llvm-lto/llvm-lto.cpp b/llvm/tools/llvm-lto/llvm-lto.cpp index d883f3c..2f0a1df 100644 --- a/llvm/tools/llvm-lto/llvm-lto.cpp +++ b/llvm/tools/llvm-lto/llvm-lto.cpp @@ -197,7 +197,7 @@ static void handleDiagnostics(lto_codegen_diagnostic_severity_t Severity, } static std::string CurrentActivity; -static void diagnosticHandler(const DiagnosticInfo &DI) { +static void diagnosticHandler(const DiagnosticInfo &DI, void *Context) { raw_ostream &OS = errs(); OS << "llvm-lto: "; switch (DI.getSeverity()) { @@ -226,11 +226,6 @@ static void diagnosticHandler(const DiagnosticInfo &DI) { exit(1); } -static void diagnosticHandlerWithContext(const DiagnosticInfo &DI, - void *Context) { - diagnosticHandler(DI); -} - static void error(const Twine &Msg) { errs() << "llvm-lto: " << Msg << '\n'; exit(1); @@ -260,7 +255,7 @@ getLocalLTOModule(StringRef Path, std::unique_ptr &Buffer, Buffer = std::move(BufferOrErr.get()); CurrentActivity = ("loading file '" + Path + "'").str(); std::unique_ptr Context = llvm::make_unique(); - Context->setDiagnosticHandler(diagnosticHandlerWithContext, nullptr, true); + Context->setDiagnosticHandler(diagnosticHandler, nullptr, true); ErrorOr> Ret = LTOModule::createInLocalContext( std::move(Context), Buffer->getBufferStart(), Buffer->getBufferSize(), Options, Path); @@ -272,12 +267,9 @@ getLocalLTOModule(StringRef Path, std::unique_ptr &Buffer, /// Print some statistics on the index for each input files. void printIndexStats() { for (auto &Filename : InputFilenames) { - CurrentActivity = "loading file '" + Filename + "'"; - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile(Filename, diagnosticHandler); - error(IndexOrErr, "error " + CurrentActivity); - std::unique_ptr Index = std::move(IndexOrErr.get()); - CurrentActivity = ""; + ExitOnError ExitOnErr("llvm-lto: error loading file '" + Filename + "': "); + std::unique_ptr Index = + ExitOnErr(llvm::getModuleSummaryIndexForFile(Filename)); // Skip files without a module summary. if (!Index) report_fatal_error(Filename + " does not contain an index"); @@ -330,12 +322,9 @@ static void createCombinedModuleSummaryIndex() { ModuleSummaryIndex CombinedIndex; uint64_t NextModuleId = 0; for (auto &Filename : InputFilenames) { - CurrentActivity = "loading file '" + Filename + "'"; - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile(Filename, diagnosticHandler); - error(IndexOrErr, "error " + CurrentActivity); - std::unique_ptr Index = std::move(IndexOrErr.get()); - CurrentActivity = ""; + ExitOnError ExitOnErr("llvm-lto: error loading file '" + Filename + "': "); + std::unique_ptr Index = + ExitOnErr(llvm::getModuleSummaryIndexForFile(Filename)); // Skip files without a module summary. if (!Index) continue; @@ -400,11 +389,9 @@ loadAllFilesForIndex(const ModuleSummaryIndex &Index) { std::unique_ptr loadCombinedIndex() { if (ThinLTOIndex.empty()) report_fatal_error("Missing -thinlto-index for ThinLTO promotion stage"); - auto CurrentActivity = "loading file '" + ThinLTOIndex + "'"; - ErrorOr> IndexOrErr = - llvm::getModuleSummaryIndexForFile(ThinLTOIndex, diagnosticHandler); - error(IndexOrErr, "error " + CurrentActivity); - return std::move(IndexOrErr.get()); + ExitOnError ExitOnErr("llvm-lto: error loading file '" + ThinLTOIndex + + "': "); + return ExitOnErr(llvm::getModuleSummaryIndexForFile(ThinLTOIndex)); } static std::unique_ptr loadModule(StringRef Filename, @@ -802,7 +789,7 @@ int main(int argc, char **argv) { unsigned BaseArg = 0; LLVMContext Context; - Context.setDiagnosticHandler(diagnosticHandlerWithContext, nullptr, true); + Context.setDiagnosticHandler(diagnosticHandler, nullptr, true); LTOCodeGenerator CodeGen(Context); -- 2.7.4