From 6d8df4b6a3a46b62b1a6f6e8678ebd3acc6df8c8 Mon Sep 17 00:00:00 2001 From: Chen Gang Date: Wed, 26 Dec 2012 18:06:39 +0800 Subject: [PATCH] serial: avoid double free after call ioc4_serial_remove_one before goto out5, soft, control, serial are all assigned to idd after finish call ioc4_serial_remove_one, all resources are released we need return instead of go on, or double free Signed-off-by: Chen Gang Signed-off-by: Greg Kroah-Hartman --- drivers/tty/serial/ioc4_serial.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/tty/serial/ioc4_serial.c b/drivers/tty/serial/ioc4_serial.c index 3e7da10..c4e30b8 100644 --- a/drivers/tty/serial/ioc4_serial.c +++ b/drivers/tty/serial/ioc4_serial.c @@ -2883,6 +2883,7 @@ ioc4_serial_attach_one(struct ioc4_driver_data *idd) /* error exits that give back resources */ out5: ioc4_serial_remove_one(idd); + return ret; out4: kfree(soft); out3: -- 2.7.4