From 6d48e2505c7a68a470e75b61ad504d51db0f8a36 Mon Sep 17 00:00:00 2001 From: Jonas Devlieghere Date: Fri, 5 Nov 2021 13:18:06 -0700 Subject: [PATCH] [lldb] Use std::string instead of llvm::Twine in GDBRemoteCommunicationClient From the documentation: A Twine is not intended for use directly and should not be stored, its implementation relies on the ability to store pointers to temporary stack objects which may be deallocated at the end of a statement. Twines should only be used accepted as const references in arguments, when an API wishes to accept possibly-concatenated strings. rdar://84799118 Differential revision: https://reviews.llvm.org/D113314 --- .../Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp index 6fd5112..364a37a 100644 --- a/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp +++ b/lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp @@ -1109,9 +1109,8 @@ void GDBRemoteCommunicationClient::MaybeEnableCompression( if (avail_type != CompressionType::None) { StringExtractorGDBRemote response; - llvm::Twine packet = "QEnableCompression:type:" + avail_name + ";"; - if (SendPacketAndWaitForResponse(packet.str(), response) != - PacketResult::Success) + std::string packet = "QEnableCompression:type:" + avail_name.str() + ";"; + if (SendPacketAndWaitForResponse(packet, response) != PacketResult::Success) return; if (response.IsOKResponse()) { -- 2.7.4