From 6d2497d48f332888a0d6d0d3e4766396822acb0e Mon Sep 17 00:00:00 2001 From: Pavel Labath Date: Wed, 30 Nov 2016 10:25:02 +0000 Subject: [PATCH] Remove a spurious reference to ProcessElfCore We were referencing a the process class from a register context, which seems intuitively wrong. Also, the comment above that code is now definitely incorrect, as ProcessElfCore now does support floating point registers. Also, the code wasn't really doing anything, as it was just skipping a zero-initialization of a field that was most likely zero-initialized anyway. Linux elf core FPR test still passes after this. llvm-svn: 288237 --- lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp | 7 +------ lldb/tools/lldb-server/CMakeLists.txt | 1 - 2 files changed, 1 insertion(+), 7 deletions(-) diff --git a/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp b/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp index 67134aa..99525b6 100644 --- a/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp +++ b/lldb/source/Plugins/Process/Utility/RegisterContextPOSIX_x86.cpp @@ -18,9 +18,9 @@ #include "lldb/Host/Endian.h" #include "lldb/Target/Target.h" #include "lldb/Target/Thread.h" +#include "lldb/Target/Process.h" #include "llvm/Support/Compiler.h" -#include "Plugins/Process/elf-core/ProcessElfCore.h" #include "RegisterContextPOSIX_x86.h" #include "RegisterContext_x86.h" @@ -373,11 +373,6 @@ RegisterContextPOSIX_x86::RegisterContextPOSIX_x86( ::memset(&m_fpr, 0, sizeof(FPR)); - // elf-core yet to support ReadFPR() - ProcessSP base = CalculateProcess(); - if (base.get()->GetPluginName() == ProcessElfCore::GetPluginNameStatic()) - return; - m_fpr_type = eNotValid; } diff --git a/lldb/tools/lldb-server/CMakeLists.txt b/lldb/tools/lldb-server/CMakeLists.txt index bb7ed35..990c419 100644 --- a/lldb/tools/lldb-server/CMakeLists.txt +++ b/lldb/tools/lldb-server/CMakeLists.txt @@ -72,7 +72,6 @@ set( LLDB_USED_LIBS lldbPluginInstructionMIPS lldbPluginInstructionMIPS64 lldbPluginObjectFilePECOFF - lldbPluginProcessElfCore lldbPluginExpressionParserClang lldbPluginExpressionParserGo ) -- 2.7.4