From 6cf5372e38e6524c9dde5fe281ed33b11465a4c4 Mon Sep 17 00:00:00 2001 From: Eunhae Choi Date: Wed, 28 Dec 2016 18:13:31 +0900 Subject: [PATCH] modify comment Change-Id: I9776417d13bfe511c5d95414c2b4f3521937b19f (cherry picked from commit c1960be2b37bbd3d5c1582918f4ff9fa762c9609) --- src/mm_player_priv.c | 31 ++++++++++++++----------------- 1 file changed, 14 insertions(+), 17 deletions(-) diff --git a/src/mm_player_priv.c b/src/mm_player_priv.c index 44e3086..e94848c 100644 --- a/src/mm_player_priv.c +++ b/src/mm_player_priv.c @@ -1040,7 +1040,7 @@ __mmplayer_handle_buffering_message(mm_player_t* player) break; case MM_PLAYER_STATE_PLAYING: - /*[shweta.agg] rtsp streaming pause makes rtsp server stop sending data. */ + /* rtsp streaming pause makes rtsp server stop sending data. */ if (!MMPLAYER_IS_RTSP_STREAMING(player)) { __gst_pause ( player, TRUE ); } @@ -7595,7 +7595,7 @@ __gst_set_position(mm_player_t* player, int format, unsigned long position, gboo if (!player->duration) { if (!gst_element_query_duration(player->pipeline->mainbin[MMPLAYER_M_PIPE].gst, GST_FORMAT_TIME, &dur_nsec)) { - /* [prasenjit.c] For RTSP Streaming , duration is not returned in READY state. So seek to the previous position does not work properly. + /* For RTSP Streaming , duration is not returned in READY state. So seek to the previous position does not work properly. * Added a patch to postpone the actual seek when state changes to PLAY. Sending a fake SEEK_COMPLETED event to finish the current request. */ if ((MMPLAYER_IS_RTSP_STREAMING( player )) && (__mmplayer_get_stream_service_type(player) != STREAMING_SERVICE_LIVE)) { player->pending_seek.is_pending = TRUE; @@ -7636,12 +7636,10 @@ __gst_set_position(mm_player_t* player, int format, unsigned long position, gboo LOGD("seeking to(%lu) msec, duration is %d msec\n", position, dur_msec); - /* - [prasenjit.c] For rtspsrc stack , npt-start value coming from server is used for finding the current position. - But when a rtsp clip (especially from Youtube Desktop View) is paused and kept for sometime,npt-start is still increasing. - This causes problem is position calculation during normal pause resume scenarios also. - Currently during seek , we are sending the current position to rtspsrc module for position saving for later use. - */ + /* For rtspsrc stack , npt-start value coming from server is used for finding the current position. + But when a rtsp clip (especially from Youtube Desktop View) is paused and kept for sometime,npt-start is still increasing. + This causes problem is position calculation during normal pause resume scenarios also. + Currently during seek , we are sending the current position to rtspsrc module for position saving for later use. */ if ((MMPLAYER_IS_RTSP_STREAMING( player )) && (__mmplayer_get_stream_service_type(player) != STREAMING_SERVICE_LIVE)) { if (!gst_element_query_position(player->pipeline->mainbin[MMPLAYER_M_PIPE].gst, GST_FORMAT_TIME, &pos_nsec)) @@ -9782,7 +9780,7 @@ _mmplayer_pause(MMHandleType hplayer) // @ mm_attrs_get_int_by_name(player->attrs, "profile_prepare_async", &async); LOGD("prepare working mode : %s", (async ? "async" : "sync")); - /* [shweta.agg] Changing back sync of rtspsrc to async */ + /* Changing back sync of rtspsrc to async */ if (MMPLAYER_IS_RTSP_STREAMING(player)) { LOGD("async prepare working mode for rtsp"); async = TRUE; @@ -9800,12 +9798,11 @@ _mmplayer_pause(MMHandleType hplayer) // @ LOGW("getting current position failed in paused\n"); player->last_position = pos_msec; - /* - [prasenjit.c] For rtspsrc stack , npt-start value coming from server is used for finding the current position. - But when a rtsp clip (especially from Youtube Desktop View) is paused and kept for sometime,npt-start is still increasing. - This causes problem is position calculation during normal pause resume scenarios also. - Currently during pause , we are sending the current position to rtspsrc module for position saving. - */ + + /* For rtspsrc stack , npt-start value coming from server is used for finding the current position. + But when a rtsp clip (especially from Youtube Desktop View) is paused and kept for sometime,npt-start is still increasing. + This causes problem is position calculation during normal pause resume scenarios also. + Currently during pause , we are sending the current position to rtspsrc module for position saving. */ if ((MMPLAYER_IS_RTSP_STREAMING( player )) && (__mmplayer_get_stream_service_type(player) != STREAMING_SERVICE_LIVE)) { g_object_set( player->pipeline->mainbin[MMPLAYER_M_SRC].gst, "resume-position", player->last_position, NULL ); @@ -9846,7 +9843,7 @@ _mmplayer_resume(MMHandleType hplayer) MMPLAYER_RETURN_VAL_IF_FAIL(player, MM_ERROR_PLAYER_NOT_INITIALIZED); - /* [shweta.agg] Changing back sync mode rtspsrc to async */ + /* Changing back sync mode rtspsrc to async */ if ((MMPLAYER_IS_RTSP_STREAMING(player))) { LOGD("async resume for rtsp case"); async = TRUE; @@ -13563,7 +13560,7 @@ __gst_send_event_to_sink(mm_player_t* player, GstEvent* event) MMPLAYER_RETURN_VAL_IF_FAIL(player, FALSE); MMPLAYER_RETURN_VAL_IF_FAIL(event, FALSE); - /*[shweta.agg] While adding subtitles in live feeds seek is getting called. + /* While adding subtitles in live feeds seek is getting called. Adding defensive check in framework layer.*/ if (GST_EVENT_TYPE(event) == GST_EVENT_SEEK) { if (MMPLAYER_IS_LIVE_STREAMING (player)) { -- 2.7.4