From 6c96d6564c5de960b20601a7f22259221b20e856 Mon Sep 17 00:00:00 2001 From: titzer Date: Wed, 13 May 2015 06:50:41 -0700 Subject: [PATCH] [turbofan] Reenable feedback for LoadNamed. R=jarin@chromium.org BUG= Review URL: https://codereview.chromium.org/1140943003 Cr-Commit-Position: refs/heads/master@{#28398} --- src/compiler/js-type-feedback.cc | 1 + src/flag-definitions.h | 3 +-- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/src/compiler/js-type-feedback.cc b/src/compiler/js-type-feedback.cc index 04861ea..7cccfa7 100644 --- a/src/compiler/js-type-feedback.cc +++ b/src/compiler/js-type-feedback.cc @@ -276,6 +276,7 @@ Reduction JSTypeFeedbackSpecializer::ReduceJSLoadProperty(Node* node) { Reduction JSTypeFeedbackSpecializer::ReduceJSStoreNamed(Node* node) { DCHECK(node->opcode() == IrOpcode::kJSStoreNamed); + if (true) return NoChange(); // TODO(titzer): storenamed is broken Node* frame_state_before = GetFrameStateBefore(node); if (frame_state_before == nullptr) return NoChange(); diff --git a/src/flag-definitions.h b/src/flag-definitions.h index 6d63129..70d40b3 100644 --- a/src/flag-definitions.h +++ b/src/flag-definitions.h @@ -385,8 +385,7 @@ DEFINE_BOOL(omit_map_checks_for_leaf_maps, true, DEFINE_BOOL(turbo, false, "enable TurboFan compiler") DEFINE_BOOL(turbo_greedy_regalloc, false, "use the greedy register allocator") DEFINE_IMPLICATION(turbo, turbo_deoptimization) -// TODO(titzer): turn back on type feedback in turbo mode. -// DEFINE_IMPLICATION(turbo, turbo_type_feedback) +DEFINE_IMPLICATION(turbo, turbo_type_feedback) DEFINE_STRING(turbo_filter, "~~", "optimization filter for TurboFan compiler") DEFINE_BOOL(trace_turbo, false, "trace generated TurboFan IR") DEFINE_BOOL(trace_turbo_graph, false, "trace generated TurboFan graphs") -- 2.7.4