From 6c6baa841662e1ab46353fee3c618d9f347ce06e Mon Sep 17 00:00:00 2001 From: Bhumika Goyal Date: Fri, 26 Feb 2016 15:34:32 +0530 Subject: [PATCH] Staging: gdm724x: Use min instead of ternary operator This patch replaces ternary operator with macro min as it shorter and thus increases code readability. Macro min return the minimum of the two compared values. Made a semantic patch for changes: @@ type T; T x; T y; @@ ( - x < y ? x : y + min(x,y) | - x > y ? x : y + max(x,y) ) Signed-off-by: Bhumika Goyal Signed-off-by: Greg Kroah-Hartman --- drivers/staging/gdm724x/gdm_mux.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/gdm724x/gdm_mux.c b/drivers/staging/gdm724x/gdm_mux.c index 937010b..6bedd66 100644 --- a/drivers/staging/gdm724x/gdm_mux.c +++ b/drivers/staging/gdm724x/gdm_mux.c @@ -433,7 +433,7 @@ static int gdm_mux_send_control(void *priv_dev, int request, int value, if (ret < 0) pr_err("usb_control_msg error: %d\n", ret); - return ret < 0 ? ret : 0; + return min(ret, 0); } static void release_usb(struct mux_dev *mux_dev) -- 2.7.4