From 6c4467a7ce20faed01530e224cb52f30e1feef28 Mon Sep 17 00:00:00 2001 From: Taehyub Kim Date: Thu, 26 Oct 2017 11:17:50 +0900 Subject: [PATCH] Revert "[Accessibility]: Access frame going behind popup issue fix when popup is created in transition,finished callback." This reverts commit 70f64ff792790cf06528bd1bd98fd37ed05dfda2. Ic52cb8faa0c122883a2bff33fb853a51f8f54ed5 Change-Id: I5790d4d1f1575a8cd7ec0e160426a4b13003a17d --- src/lib/elc_naviframe.c | 61 ++++++++++++++++++++----------------------------- 1 file changed, 25 insertions(+), 36 deletions(-) diff --git a/src/lib/elc_naviframe.c b/src/lib/elc_naviframe.c index fabc264..565ffaf 100644 --- a/src/lib/elc_naviframe.c +++ b/src/lib/elc_naviframe.c @@ -687,12 +687,6 @@ _elm_naviframe_item_eo_base_destructor(Eo *eo_item, Elm_Naviframe_Item_Data *it) elm_object_signal_emit(VIEW(prev_it), "elm,state,visible", "elm"); // - //TIZEN_ONLY(20171019): add state_notify api - if (_elm_atspi_enabled()) - eo_do(VIEW(prev_it), elm_interface_atspi_accessible_state_notify( - ATSPI_STATE(ELM_ATSPI_STATE_SHOWING) | ATSPI_STATE(ELM_ATSPI_STATE_VISIBLE), EINA_TRUE)); - // - eo_do(WIDGET(prev_it), eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, EO_OBJ(prev_it))); } @@ -1299,6 +1293,21 @@ _on_item_pop_finished(void *data, sd->popping = eina_list_remove(sd->popping, it); eo_do(EO_OBJ(it), elm_wdg_item_del()); + + //TIZEN_ONLY(20161122): add state_notify api + Eo *eo_top = elm_naviframe_top_item_get(widget); + if (eo_top) + { + ELM_NAVIFRAME_ITEM_DATA_GET(eo_top, top); + _elm_win_default_label_obj_append(VIEW(top)); + + if (_elm_atspi_enabled()) + { + eo_do(VIEW(top), elm_interface_atspi_accessible_state_notify( + ATSPI_STATE(ELM_ATSPI_STATE_SHOWING) | ATSPI_STATE(ELM_ATSPI_STATE_VISIBLE), EINA_TRUE)); + } + } + // } /* "elm,state,new,pushed", @@ -1331,23 +1340,16 @@ _on_item_show_finished(void *data, evas_object_freeze_events_set(VIEW(it), EINA_FALSE); it->pushing = EINA_FALSE; - //TIZEN_ONLY(20161122): add state_notify api - if (EO_OBJ(it) == elm_naviframe_top_item_get(WIDGET(it))) - { - _elm_win_default_label_obj_append(VIEW(it)); - - if (_elm_atspi_enabled()) - { - eo_do(VIEW(it), elm_interface_atspi_accessible_state_notify( - ATSPI_STATE(ELM_ATSPI_STATE_SHOWING) | ATSPI_STATE(ELM_ATSPI_STATE_VISIBLE), EINA_TRUE)); - } - } - // eo_do(WIDGET(it), eo_event_callback_call(ELM_NAVIFRAME_EVENT_TRANSITION_FINISHED, EO_OBJ(it))); if (EO_OBJ(it) == elm_naviframe_top_item_get(WIDGET(it))) - eo_do(WIDGET(it), eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, EO_OBJ(it))); + { + eo_do(WIDGET(it), eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, EO_OBJ(it))); + //TIZEN_ONLY(20170919): Handle default label object + _elm_win_default_label_obj_append(VIEW(it)); + // + } } static void @@ -1897,10 +1899,10 @@ _item_push_helper(Elm_Naviframe_Item_Data *item) if (!top_item) { - //TIZEN_ONLY(20170919): Handle default label object - _elm_win_default_label_obj_append(VIEW(item)); - // eo_do(obj, eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, EO_OBJ(item))); + //TIZEN_ONLY(20170919): Handle default label object + _elm_win_default_label_obj_append(VIEW(item)); + // } } @@ -2021,11 +2023,6 @@ _elm_naviframe_item_insert_after(Eo *obj, Elm_Naviframe_Data *sd, Elm_Object_Ite _resize_object_reset(obj, it); evas_object_show(VIEW(it)); evas_object_hide(VIEW(after)); - //TIZEN_ONLY(20171019): add state_notify api - if (_elm_atspi_enabled()) - eo_do(VIEW(after), elm_interface_atspi_accessible_state_notify( - ATSPI_STATE(ELM_ATSPI_STATE_SHOWING) | ATSPI_STATE(ELM_ATSPI_STATE_VISIBLE), EINA_TRUE)); - // if (elm_object_focus_allow_get(VIEW(it))) elm_object_focus_set(VIEW(it), EINA_TRUE); else @@ -2052,15 +2049,7 @@ _elm_naviframe_item_insert_after(Eo *obj, Elm_Naviframe_Data *sd, Elm_Object_Ite elm_layout_sizing_eval(obj); if (top_inserted) - { - //TIZEN_ONLY(20171019): Handle default label object - _elm_win_default_label_obj_append(VIEW(it)); - if (_elm_atspi_enabled()) - eo_do(VIEW(it), elm_interface_atspi_accessible_state_notify( - ATSPI_STATE(ELM_ATSPI_STATE_SHOWING) | ATSPI_STATE(ELM_ATSPI_STATE_VISIBLE), EINA_TRUE)); - // - eo_do(obj, eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, eo_item)); - } + eo_do(obj, eo_event_callback_call(ELM_NAVIFRAME_EVENT_ITEM_ACTIVATED, eo_item)); return eo_item; } -- 2.7.4