From 6bf1769835fa9969e66e69a1b3fa89bc86b5426a Mon Sep 17 00:00:00 2001 From: Alexander Kanevskiy Date: Tue, 13 Aug 2013 13:50:12 +0300 Subject: [PATCH] make code more generic --- gerrithooks/common.py | 14 +++++++++++++- 1 file changed, 13 insertions(+), 1 deletion(-) diff --git a/gerrithooks/common.py b/gerrithooks/common.py index 6580bae..a514167 100644 --- a/gerrithooks/common.py +++ b/gerrithooks/common.py @@ -26,11 +26,23 @@ from gerrithooks.misc import find_config, configure_logging, daemonize from pkg_resources import iter_entry_points -def run_plugin_hooks(hook, params, logger): +def run_plugin_hooks(hook, parser): """ Common code for every hook. Must provide parsed params and logger """ + # set up logger + logger = configure_logging(os.path.basename(sys.argv[0])) + + # get parameters from command line + params = parser(sys.argv[1:]) + + params_keys = sorted([ key for key in dir(params) + if not (key.startswith("_") or key =="debug") ]) + params_string = ", ".join(["%s: %s" % (key,getattr(params,key)) for key in + params_keys ]) + logger.info("Event %s: %s", hook, params_string) + if not 'debug' in params or not params.debug: logger.debug("Daemonizing...") daemonize() -- 2.34.1