From 6bdff90c02ebf588b9c9a8764dd13a63bd220085 Mon Sep 17 00:00:00 2001 From: Daniel Mack Date: Thu, 8 Jan 2015 17:34:39 +0100 Subject: [PATCH] metadata: simplify OOM check for cmdline Signed-off-by: Daniel Mack --- metadata.c | 8 +++----- 1 file changed, 3 insertions(+), 5 deletions(-) diff --git a/metadata.c b/metadata.c index 6f2b844..492cc42 100644 --- a/metadata.c +++ b/metadata.c @@ -404,12 +404,10 @@ int kdbus_meta_add_current(struct kdbus_meta *meta, u64 which) s = (const char __user *)mm->arg_start; meta->cmdline = strndup_user(s, len); - if (!meta->cmdline) { - mmput(mm); - return -ENOMEM; - } - mmput(mm); + + if (!meta->cmdline) + return -ENOMEM; } meta->collected |= KDBUS_ATTACH_CMDLINE; -- 2.34.1