From 6bd27152e18583f130b32b816e6ed599fd0db4b8 Mon Sep 17 00:00:00 2001 From: Roman Lebedev Date: Tue, 10 Apr 2018 20:07:02 +0000 Subject: [PATCH] [clang-tidy][Fuchsia]: don't forget to actually link to Google Module. Fixes build for me: [1/7] Linking CXX shared library lib/libclangTidyFuchsiaModule.so.7svn FAILED: lib/libclangTidyFuchsiaModule.so.7svn <...> /usr/local/bin/ld.lld: error: undefined symbol: clang::tidy::google::build::UnnamedNamespaceInHeaderCheck::UnnamedNamespaceInHeaderCheck(llvm::StringRef, clang::tidy::ClangTidyContext*) >>> referenced by FuchsiaTidyModule.cpp >>> tools/clang/tools/extra/clang-tidy/fuchsia/CMakeFiles/clangTidyFuchsiaModule.dir/FuchsiaTidyModule.cpp.o:(std::_Function_handler(llvm::StringRef)::'lambda'(llvm::StringRef, clang::tidy::ClangTidyContext*)>::_M_invoke(std::_Any_data const&, llvm::StringRef&&, clang::tidy::ClangTidyContext*&&)) Refs. D45447, rCTE329720 llvm-svn: 329749 --- clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt | 1 + 1 file changed, 1 insertion(+) diff --git a/clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt b/clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt index 0dfc04e..c2ed252 100644 --- a/clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt +++ b/clang-tools-extra/clang-tidy/fuchsia/CMakeLists.txt @@ -15,5 +15,6 @@ add_clang_library(clangTidyFuchsiaModule clangBasic clangLex clangTidy + clangTidyGoogleModule clangTidyUtils ) -- 2.7.4