From 6b8d75425eebee8c0c2b279ac2cf0c669d1846fe Mon Sep 17 00:00:00 2001 From: Carl Ritson Date: Wed, 19 Sep 2018 16:32:12 +0000 Subject: [PATCH] [AMDGPU] Add instruction selection for i1 to f16 conversion Summary: This is required for GPUs with 16 bit instructions where f16 is a legal register type and hence int_to_fp i1 to f16 is not lowered by legalizing. Reviewers: arsenm, nhaehnle Reviewed By: nhaehnle Subscribers: kzhuravl, jvesely, wdng, nhaehnle, yaxunl, dstuttard, tpr, t-tye, llvm-commits Differential Revision: https://reviews.llvm.org/D52018 Change-Id: Ie4c0fd6ced7cf10ad612023c6879724d9ded5851 llvm-svn: 342558 --- llvm/lib/Target/AMDGPU/SIInstructions.td | 10 ++++++++++ llvm/test/CodeGen/AMDGPU/sitofp.f16.ll | 19 +++++++++++++++++++ llvm/test/CodeGen/AMDGPU/uitofp.f16.ll | 19 +++++++++++++++++++ 3 files changed, 48 insertions(+) diff --git a/llvm/lib/Target/AMDGPU/SIInstructions.td b/llvm/lib/Target/AMDGPU/SIInstructions.td index ee545e0..8695b16 100644 --- a/llvm/lib/Target/AMDGPU/SIInstructions.td +++ b/llvm/lib/Target/AMDGPU/SIInstructions.td @@ -1321,6 +1321,16 @@ def : GCNPat < >; def : GCNPat < + (f16 (sint_to_fp i1:$src)), + (V_CVT_F16_F32_e32 (V_CNDMASK_B32_e64 (i32 0), (i32 CONST.FP32_NEG_ONE), $src)) +>; + +def : GCNPat < + (f16 (uint_to_fp i1:$src)), + (V_CVT_F16_F32_e32 (V_CNDMASK_B32_e64 (i32 0), (i32 CONST.FP32_ONE), $src)) +>; + +def : GCNPat < (f32 (sint_to_fp i1:$src)), (V_CNDMASK_B32_e64 (i32 0), (i32 CONST.FP32_NEG_ONE), $src) >; diff --git a/llvm/test/CodeGen/AMDGPU/sitofp.f16.ll b/llvm/test/CodeGen/AMDGPU/sitofp.f16.ll index 31d3466..231d3a6d 100644 --- a/llvm/test/CodeGen/AMDGPU/sitofp.f16.ll +++ b/llvm/test/CodeGen/AMDGPU/sitofp.f16.ll @@ -92,4 +92,23 @@ entry: ret void } +; FUNC-LABEL: {{^}}s_sint_to_fp_i1_to_f16: +; GCN-DAG: v_cmp_le_f32_e32 [[CMP0:vcc]], 1.0, {{v[0-9]+}} +; GCN-DAG: v_cmp_le_f32_e64 [[CMP1:s\[[0-9]+:[0-9]+\]]], 0, {{v[0-9]+}} +; GCN: s_xor_b64 [[R_CMP:s\[[0-9]+:[0-9]+\]]], [[CMP1]], [[CMP0]] +; GCN: v_cndmask_b32_e64 [[RESULT:v[0-9]+]], 0, -1.0, [[R_CMP]] +; GCN-NEXT: v_cvt_f16_f32_e32 [[R_F16:v[0-9]+]], [[RESULT]] +; GCN: buffer_store_short +; GCN: s_endpgm +define amdgpu_kernel void @s_sint_to_fp_i1_to_f16(half addrspace(1)* %out, float addrspace(1)* %in0, float addrspace(1)* %in1) { + %a = load float, float addrspace(1) * %in0 + %b = load float, float addrspace(1) * %in1 + %acmp = fcmp oge float %a, 0.000000e+00 + %bcmp = fcmp oge float %b, 1.000000e+00 + %result = xor i1 %acmp, %bcmp + %fp = sitofp i1 %result to half + store half %fp, half addrspace(1)* %out + ret void +} + ; v2f16 = sitofp v2i64 is in sint_to_fp.i64.ll diff --git a/llvm/test/CodeGen/AMDGPU/uitofp.f16.ll b/llvm/test/CodeGen/AMDGPU/uitofp.f16.ll index 0e7250f..9cedce7 100644 --- a/llvm/test/CodeGen/AMDGPU/uitofp.f16.ll +++ b/llvm/test/CodeGen/AMDGPU/uitofp.f16.ll @@ -92,4 +92,23 @@ entry: ret void } +; FUNC-LABEL: {{^}}s_uint_to_fp_i1_to_f16: +; GCN-DAG: v_cmp_le_f32_e32 [[CMP0:vcc]], 1.0, {{v[0-9]+}} +; GCN-DAG: v_cmp_le_f32_e64 [[CMP1:s\[[0-9]+:[0-9]+\]]], 0, {{v[0-9]+}} +; GCN: s_xor_b64 [[R_CMP:s\[[0-9]+:[0-9]+\]]], [[CMP1]], [[CMP0]] +; GCN: v_cndmask_b32_e64 [[RESULT:v[0-9]+]], 0, 1.0, [[R_CMP]] +; GCN-NEXT: v_cvt_f16_f32_e32 [[R_F16:v[0-9]+]], [[RESULT]] +; GCN: buffer_store_short +; GCN: s_endpgm +define amdgpu_kernel void @s_uint_to_fp_i1_to_f16(half addrspace(1)* %out, float addrspace(1)* %in0, float addrspace(1)* %in1) { + %a = load float, float addrspace(1) * %in0 + %b = load float, float addrspace(1) * %in1 + %acmp = fcmp oge float %a, 0.000000e+00 + %bcmp = fcmp oge float %b, 1.000000e+00 + %result = xor i1 %acmp, %bcmp + %fp = uitofp i1 %result to half + store half %fp, half addrspace(1)* %out + ret void +} + ; f16 = uitofp i64 is in uint_to_fp.i64.ll -- 2.7.4