From 6b500dc5f9c37ded310ebf626f655a33030b7914 Mon Sep 17 00:00:00 2001 From: Rui Ueyama Date: Thu, 3 Mar 2016 00:51:23 +0000 Subject: [PATCH] Simplify string operations. NFC. llvm-svn: 262569 --- lld/lib/Config/Version.cpp | 25 +++++++++---------------- 1 file changed, 9 insertions(+), 16 deletions(-) diff --git a/lld/lib/Config/Version.cpp b/lld/lib/Config/Version.cpp index 2f06d20..60687b9 100644 --- a/lld/lib/Config/Version.cpp +++ b/lld/lib/Config/Version.cpp @@ -35,22 +35,15 @@ StringRef getLLDRevision() { } std::string getLLDRepositoryVersion() { - std::string buf; - llvm::raw_string_ostream OS(buf); - std::string Path = getLLDRepositoryPath(); - std::string Revision = getLLDRevision(); - if (!Path.empty() || !Revision.empty()) { - OS << '('; - if (!Path.empty()) - OS << Path; - if (!Revision.empty()) { - if (!Path.empty()) - OS << ' '; - OS << Revision; - } - OS << ')'; - } - return OS.str(); + std::string S = getLLDRepositoryPath(); + std::string T = getLLDRevision(); + if (S.empty() && T.empty()) + return ""; + if (!S.empty() && !T.empty()) + return "(" + S + " " + T + ")"; + if (!S.empty()) + return "(" + S + ")"; + return "(" + T + ")"; } StringRef getLLDVersion() { -- 2.7.4