From 6b1c0197766ccebdfd6fc28329a03483a477006f Mon Sep 17 00:00:00 2001 From: "alph@chromium.org" Date: Tue, 1 Jul 2014 10:10:12 +0000 Subject: [PATCH] Make JsNative1JsNative2JsSample cctest work on Win Release MSVC optimization realizes that CallJsFunction2 is just the same as CallJsFunction, so it eliminates the former making the call stack contain two instances of the same function. The patch makes two functions distinct. LOG=N BUG=v8:3055 R=aandrey@chromium.org, jkummerow@chromium.org, yurys@chromium.org Review URL: https://codereview.chromium.org/357383003 git-svn-id: https://v8.googlecode.com/svn/branches/bleeding_edge@22113 ce2b1a6d-e550-0410-aec6-3dcde31c8c00 --- test/cctest/cctest.status | 3 --- test/cctest/test-cpu-profiler.cc | 1 + 2 files changed, 1 insertion(+), 3 deletions(-) diff --git a/test/cctest/cctest.status b/test/cctest/cctest.status index f4fadb3..78f94a0 100644 --- a/test/cctest/cctest.status +++ b/test/cctest/cctest.status @@ -152,9 +152,6 @@ # BUG(2999). 'test-cpu-profiler/CollectCpuProfile': [PASS, FAIL], - # BUG(3055). - 'test-cpu-profiler/JsNative1JsNative2JsSample': [PASS, ['mode == release', FAIL], ['mode == debug', FLAKY]], - # BUG(3005). 'test-alloc/CodeRange': [PASS, FAIL], diff --git a/test/cctest/test-cpu-profiler.cc b/test/cctest/test-cpu-profiler.cc index ef1c0f5..cbcac28 100644 --- a/test/cctest/test-cpu-profiler.cc +++ b/test/cctest/test-cpu-profiler.cc @@ -1490,6 +1490,7 @@ TEST(JsNativeJsRuntimeJsSample) { static void CallJsFunction2(const v8::FunctionCallbackInfo& info) { + v8::base::OS::Print("In CallJsFunction2\n"); CallJsFunction(info); } -- 2.7.4