From 6b017a11ba4ae6547a975a6b8343dfe3fdb5b5b1 Mon Sep 17 00:00:00 2001 From: Sanjoy Das Date: Wed, 2 Mar 2016 02:56:29 +0000 Subject: [PATCH] Add a comment with a rational for the unusual code structure llvm-svn: 262454 --- llvm/lib/Analysis/ScalarEvolution.cpp | 3 +++ 1 file changed, 3 insertions(+) diff --git a/llvm/lib/Analysis/ScalarEvolution.cpp b/llvm/lib/Analysis/ScalarEvolution.cpp index 489c436..f55fcfe 100644 --- a/llvm/lib/Analysis/ScalarEvolution.cpp +++ b/llvm/lib/Analysis/ScalarEvolution.cpp @@ -4577,6 +4577,9 @@ ConstantRange ScalarEvolution::getRangeViaFactoring(const SCEV *Start, // from deep in the call stack, and calling getSCEV (on a sext instruction, // say) can end up caching a suboptimal value. + // FIXME: without the explicit `this` receiver below, MSVC errors out with + // C2352 and C2512 (otherwise it isn't needed). + const SCEV *TrueStart = this->getConstant(*StartPattern.TrueValue + Offset); const SCEV *TrueStep = this->getConstant(*StepPattern.TrueValue); const SCEV *FalseStart = this->getConstant(*StartPattern.FalseValue + Offset); -- 2.7.4